Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use new pytest api to keep building with pytest 5 #353

Merged
merged 2 commits into from
Jul 25, 2019
Merged

Use new pytest api to keep building with pytest 5 #353

merged 2 commits into from
Jul 25, 2019

Conversation

scarabeusiv
Copy link
Contributor

Matches was changed to match with at least pytest4 and from pytest 5.0+ it does not work.

@scarabeusiv
Use new pytest api to keep building with pytest 5
b482417 
Matches was changed to match with at least pytest4 and from pytest 5.0+ it does not work.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2019
@busunkim96
Copy link
Contributor

busunkim96 commented Jul 22, 2019 •
edited
Loading

@scarabeusiv Thank you! Could you also change the version pin for pytest in tox.ini?

@scarabeusiv
Copy link
Contributor Author

Sure, commit added.

@busunkim96 busunkim96 merged commit 938e5d9 into googleapis:master Jul 25, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scarabeusiv @busunkim96 @googlebot