Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: logger configuration in service account JWT header #525

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

johannlejeune
Copy link

@johannlejeune johannlejeune commented Feb 27, 2025

Fix a typo preventing the user from customizing the logger when initializing a new Google::Auth::ServiceAccountJwtHeaderCredentials without a scope

I wasn't able to sign the CLA, got a 400 Bad Request upon form submission, I'll try again later 🤷

@johannlejeune johannlejeune requested a review from a team as a code owner February 27, 2025 10:57
Copy link

google-cla bot commented Feb 27, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding this! Let me know if you're still having trouble with the CLA form on a retry.

@johannlejeune
Copy link
Author

Thank you for finding this! Let me know if you're still having trouble with the CLA form on a retry.

Tried again, now I'm getting "A server error occurred, please try your request again." 😂

@johannlejeune
Copy link
Author

Tried again today, still getting "A server error occurred, please try your request again." ~40s after submitting the form

@johannlejeune
Copy link
Author

@dazuma Was finally able to sign it 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants