feat(spanner): implement at-least-once Commit #11899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new operation, `spanner::Client::CommitAtLeastOnce()`, with all its caveats, that exposes the single-RPC, temporary-transaction commit support. Fixes googleapis#4890.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11899 +/- ##
==========================================
- Coverage 93.66% 93.66% -0.01%
==========================================
Files 1838 1838
Lines 166240 166358 +118
==========================================
+ Hits 155711 155815 +104
- Misses 10529 10543 +14
☔ View full report in Codecov by Sentry. |
coryan
approved these changes
Jun 15, 2023
| * | ||
| * @note Prefer the `Commit` overloads if you want exactly-once semantics | ||
| * or want to reapply mutations after a `kAborted` error. | ||
| * |
There was a problem hiding this comment.
It would be nice to have a really simple example using this function.
There was a problem hiding this comment.
Good idea. I'll add one in a follow-up.
coryan
added
the
do not merge
devbww
removed
the
do not merge
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new operation,
spanner::Client::CommitAtLeastOnce(), with all its caveats, that exposes the single-RPC, temporary-transaction commit support.Fixes #4890.
This change is