Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(spanner): add samples for instance partitions #14574

Merged

Conversation

varuncnaik
Copy link
Contributor

@varuncnaik varuncnaik commented Jul 25, 2024

Add samples for instance partitions.


This change is Reviewable

@varuncnaik varuncnaik requested a review from a team as a code owner July 25, 2024 23:27
Copy link

snippet-bot bot commented Jul 25, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels Jul 25, 2024
@scotthart
Copy link
Member

/gcbrun

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 15.78947% with 16 lines in your changes missing coverage. Please review.

Project coverage is 93.58%. Comparing base (c93210d) to head (be1608e).
Report is 2 commits behind head on main.

Files Patch % Lines
google/cloud/spanner/samples/samples.cc 15.78% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14574      +/-   ##
==========================================
- Coverage   93.59%   93.58%   -0.01%     
==========================================
  Files        2318     2318              
  Lines      207162   207181      +19     
==========================================
+ Hits       193887   193899      +12     
- Misses      13275    13282       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scotthart scotthart merged commit df06612 into googleapis:main Jul 26, 2024
69 of 70 checks passed
@varuncnaik varuncnaik deleted the spanner-create-instance-partition branch August 7, 2024 17:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants