Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs(pubsub): Add Pub/Sub ingestion from Kafka samples #14954

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

michaelpri10
Copy link
Contributor

@michaelpri10 michaelpri10 commented Jan 23, 2025

Add samples and tests for Cloud Pub/Sub ingestion from Kafka.


This change is Reviewable

@michaelpri10 michaelpri10 requested a review from a team as a code owner January 23, 2025 21:53
@product-auto-label product-auto-label bot added api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples. labels Jan 23, 2025
@michaelpri10
Copy link
Contributor Author

/gcbrun

@scotthart
Copy link
Member

/gcbrun

Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @michaelpri10)


google/cloud/pubsub/samples/topic_admin_samples.cc line 283 at r1 (raw file):

  [](pubsub_admin::TopicAdminClient client, std::string project_id,
     std::string topic_id, std::string cluster_arn, std::string msk_topic,
     std::string aws_role_arn, std::string gcp_service_account) {

For these strings that are only used once, either std::move them when they are used or change the parameter type from std::string to std::string const&.

Here and elsewhere in the changes.

Copy link
Contributor Author

@michaelpri10 michaelpri10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @scotthart)


google/cloud/pubsub/samples/topic_admin_samples.cc line 283 at r1 (raw file):

Previously, scotthart (Scott Hart) wrote…

For these strings that are only used once, either std::move them when they are used or change the parameter type from std::string to std::string const&.

Here and elsewhere in the changes.

Done.

@scotthart
Copy link
Member

/gcbrun

Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 70.58824% with 30 lines in your changes missing coverage. Please review.

Project coverage is 92.90%. Comparing base (2335df2) to head (784f1cc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
google/cloud/pubsub/samples/topic_admin_samples.cc 70.58% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14954      +/-   ##
==========================================
- Coverage   92.91%   92.90%   -0.02%     
==========================================
  Files        2351     2351              
  Lines      210083   210185     +102     
==========================================
+ Hits       195201   195266      +65     
- Misses      14882    14919      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scotthart
Copy link
Member

/gcbrun

@scotthart scotthart enabled auto-merge (squash) January 24, 2025 22:23
@scotthart scotthart merged commit 59edec8 into googleapis:main Jan 24, 2025
73 of 74 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants