Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test(bigtable): Add retries while getting app profile #8751

Merged
merged 2 commits into from
Oct 25, 2023
Merged

test(bigtable): Add retries while getting app profile #8751

merged 2 commits into from
Oct 25, 2023

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Oct 19, 2023

Issue: TestIntegration_InstanceAdminClient_AppProfile fails with error:

integration_test.go:2868: empty description update : got profile : name:"projects/dulcet-port-762/instances/gc-bt-it-instance/appProfiles/app_profile_idc1652188"  description:"creating new app profile 1"  single_cluster_routing:{cluster_id:"gc-bt-it-cluster"}  standard_isolation:{priority:PRIORITY_HIGH}, want profile: name:"projects/dulcet-port-762/instances/gc-bt-it-instance/appProfiles/app_profile_idc1652188"  single_cluster_routing:{cluster_id:"gc-bt-it-cluster"}

Cause: App profile update takes a bit of time to reflect
Fix: Retry getting updated app profile

@bhshkh bhshkh requested review from a team as code owners October 19, 2023 23:50
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the Bigtable API. labels Oct 19, 2023
@bhshkh bhshkh linked an issue Oct 19, 2023 that may be closed by this pull request
bigtable: TestIntegration_InstanceAdminClient_AppProfile failed #8742
Closed
@bhshkh bhshkh requested a review from enocom October 23, 2023 14:35
@bhshkh bhshkh merged commit 7bb630b into googleapis:main Oct 25, 2023
@bhshkh bhshkh deleted the fix/issue-8742 branch October 25, 2023 20:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@enocom enocom enocom approved these changes

@kolea2 kolea2 kolea2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bigtable: TestIntegration_InstanceAdminClient_AppProfile failed
3 participants
@bhshkh @enocom @kolea2