delete pull-related methods from PubSub #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, provide a way to create the Subscriber object.
googlebot
added
the
cla: yes
davidtorres
reviewed
Dec 21, 2016
| return modifyAckDeadlineAsync(subscription, 0, TimeUnit.SECONDS, ackIds); | ||
| } | ||
|
|
||
| @Override | ||
| public void modifyAckDeadline(String subscription, int deadline, TimeUnit unit, String ackId, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
pongad
commented
Dec 21, 2016
| .maxQueuedCallbacks(MAX_QUEUED_CALLBACKS.getInteger(optionMap)) | ||
| .executorFactory(EXECUTOR_FACTORY.getExecutorFactory(optionMap)) | ||
| public Subscriber subscriber(SubscriptionInfo subscription, Subscriber.MessageReceiver receiver) { | ||
| // TODO(pongad): Provide a way to pass in the rest of the options. |
|
Changes Unknown when pulling 9df40ba on pongad:del-pull into ** on GoogleCloudPlatform:pubsub-hp**. |
|
@davidtorres PTAL |
|
Changes Unknown when pulling 2239a50 on pongad:del-pull into ** on GoogleCloudPlatform:pubsub-hp**. |
|
Changes Unknown when pulling 2239a50 on pongad:del-pull into ** on GoogleCloudPlatform:pubsub-hp**. |
|
A couple high-level things:
|
|
|
Add a TODO to settle the issue of executors & channels. Otherwise LGTM. |
|
Changes Unknown when pulling 6cd3804 on pongad:del-pull into ** on GoogleCloudPlatform:pubsub-hp**. |
6 tasks
|
Changes Unknown when pulling 46bf12f on pongad:del-pull into ** on GoogleCloudPlatform:pubsub-hp**. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, provide a way to create the Subscriber object.
cc @davidtorres