return Name objects instead of plain String #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Changes Unknown when pulling 090326c on pongad:return-name into ** on GoogleCloudPlatform:pubsub-hp**. |
| @@ -52,7 +51,7 @@ public static void main(String... args) throws Exception { | |||
| }; | |||
| Subscriber subscriber = null; | |||
| try { | |||
| subscriber = Subscriber.Builder.newBuilder(subscription, receiver).build(); | |||
| @@ -121,6 +121,7 @@ public static long getApiMaxRequestBytes() { | |||
|
|
|||
| private static final Logger logger = LoggerFactory.getLogger(Publisher.class); | |||
|
|
|||
| private final TopicName topicName; | |||
| private final String topic; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -249,6 +263,7 @@ public void terminated(State from) {} | |||
| private static class SubscriberImpl extends AbstractService { | |||
| private static final Logger logger = LoggerFactory.getLogger(Subscriber.class); | |||
|
|
|||
| private final SubscriptionName subscriptionName; | |||
| private final String subscription; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@garrettjonesgoogle PTAL |
|
LGTM |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.