Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixing dependency problems for consumers of google-cloud-java #2284

Merged
merged 1 commit into from
Jul 27, 2017
Merged

Fixing dependency problems for consumers of google-cloud-java #2284

merged 1 commit into from
Jul 27, 2017

Conversation

garrettjonesgoogle
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle commented Jul 27, 2017 •
edited
Loading

Various things:

  • Fixing the problem of maven choosing the wrong auth dependency by adding it explicitly as a dependency in google-cloud-core-grpc.
  • Adding <requireUpperBoundDeps/> to make sure we're always using the latest version of everything
  • Updated some versions that were not the latest (which I found from adding requireUpperBoundDeps)
  • Adding some special pom files which depend on a couple google-cloud-java artifacts to make sure that they don't see failures when using requireUpperBoundDeps. The auth dependency issue for error-reporting in particular doesn't show up inside google-cloud-errorreporting itself, only for a consumer of it.

Fixes #2192 .

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 27, 2017
jabubake
jabubake approved these changes Jul 27, 2017
View reviewed changes
Copy link
Contributor

@jabubake jabubake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

google-cloud-dep-verification/google-cloud-consumer/pom.xml
<name>Google Cloud Consumer</name>
<url>https://github.com/GoogleCloudPlatform/google-cloud-java/tree/master/google-cloud-consumer</url>
<description>
Package that consumes google-cloud to make sure consumers don't see dependency resolution problems.

This comment was marked as spam.

# to view

@garrettjonesgoogle
Copy link
Member Author

Merging - the mac failure was a frequently-seen timeout.

@garrettjonesgoogle garrettjonesgoogle merged commit 4e5c423 into googleapis:master Jul 27, 2017
@jabubake jabubake mentioned this pull request Jul 31, 2017
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jabubake jabubake jabubake approved these changes

@neozwu neozwu neozwu approved these changes

@vam-google vam-google Awaiting requested review from vam-google

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garrettjonesgoogle @jabubake @neozwu @googlebot