Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add contrib #583

Merged
merged 1 commit into from
Jan 26, 2016
Merged

Add contrib #583

merged 1 commit into from
Jan 26, 2016

Conversation

jean-philippe-martin
Copy link

Creating a cozy place for new contributions.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 26, 2016

Additional functionality for gcloud-java (Java idiomatic client for [Google Cloud Platform][cloud-platform] services).

Quickstart

This comment was marked as spam.

This comment was marked as spam.

@ajkannan
Copy link

A few minor comments from me, but otherwise looks good!

@@ -73,6 +73,7 @@
<module>gcloud-java-examples</module>
<module>gcloud-java-resourcemanager</module>
<module>gcloud-java-storage</module>
<module>gcloud-java-contrib</module>

This comment was marked as spam.

This comment was marked as spam.

@jean-philippe-martin
Copy link
Author

Thanks for taking a look! I'm sending an updated version.

@mziccard
Copy link
Contributor

@jean-philippe-martin Before merging do you mind squashing the commits?
@ajkannan Do you have other comments?

@jean-philippe-martin
Copy link
Author

Squashed; merging when I get the "LGTM".

@ajkannan
Copy link

LGTM

jean-philippe-martin added a commit that referenced this pull request Jan 26, 2016
@jean-philippe-martin jean-philippe-martin merged commit 25692fc into googleapis:master Jan 26, 2016
@jean-philippe-martin jean-philippe-martin deleted the add_contrib branch January 26, 2016 22:16
github-actions bot pushed a commit that referenced this pull request Oct 7, 2022
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants