-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add contrib #583
Merged
jean-philippe-martin
merged 1 commit into
googleapis:master
from
jean-philippe-martin:add_contrib
Jan 26, 2016
Merged
Add contrib #583
jean-philippe-martin
merged 1 commit into
googleapis:master
from
jean-philippe-martin:add_contrib
Jan 26, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few minor comments from me, but otherwise looks good! |
@@ -73,6 +73,7 @@ | |||
<module>gcloud-java-examples</module> | |||
<module>gcloud-java-resourcemanager</module> | |||
<module>gcloud-java-storage</module> | |||
<module>gcloud-java-contrib</module> |
Thanks for taking a look! I'm sending an updated version. |
@jean-philippe-martin Before merging do you mind squashing the commits? |
Squashed; merging when I get the "LGTM". |
LGTM |
jean-philippe-martin
added a commit
that referenced
this pull request
Jan 26, 2016
adding gcloud-java-contrib module
github-actions bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a cozy place for new contributions.