Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Datastore: bump minimum 'api_core' version to 1.4.1. #6391

Merged
merged 2 commits into from
Nov 7, 2018
Merged

Datastore: bump minimum 'api_core' version to 1.4.1. #6391

merged 2 commits into from
Nov 7, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 5, 2018

Closes #6390.

@tseaver tseaver added the api: datastore Issues related to the Datastore API. label Nov 5, 2018
@tseaver tseaver requested a review from dhermes as a code owner November 5, 2018 19:51
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 5, 2018
@tseaver tseaver removed request for tswast and alixhami November 5, 2018 21:18
@tseaver
Copy link
Contributor Author

tseaver commented Nov 6, 2018

Unrelated translation systest failure: see #6427,

- Bump minimum 'google-api_core' version for all GAPIC libs to 1.4.1.

- Lower bounds before upper bounds.

- Whitespace for legibility.

- Sort them topologically / consistently.
@tseaver
Copy link
Contributor Author

tseaver commented Nov 7, 2018

@theacodes Rebased to pick up the translation systest fix merged in #6247. PTAL.

@theacodes
Copy link
Contributor

why are we bumping this for all packages? historically, we've only bumped the version on the package that needed it.

@tseaver
Copy link
Contributor Author

tseaver commented Nov 7, 2018

@theacodes see #6128, #6390.

We don't test against older versions, so we don't know when they break until a user tries it (usually via upgrading only google-cloud-<foo>. As of today, I know that any of our currently-generated GAPIC libs need protobuf >= 3.4.0:

$ git grep -l "file=DESCRIPTOR"
asset/google/cloud/asset_v1beta1/proto/asset_service_pb2.py
asset/google/cloud/asset_v1beta1/proto/assets_pb2.py
automl/google/cloud/automl_v1beta1/proto/annotation_payload_pb2.py
automl/google/cloud/automl_v1beta1/proto/classification_pb2.py
automl/google/cloud/automl_v1beta1/proto/data_items_pb2.py
automl/google/cloud/automl_v1beta1/proto/dataset_pb2.py
automl/google/cloud/automl_v1beta1/proto/image_pb2.py
automl/google/cloud/automl_v1beta1/proto/io_pb2.py
automl/google/cloud/automl_v1beta1/proto/model_evaluation_pb2.py
automl/google/cloud/automl_v1beta1/proto/model_pb2.py
automl/google/cloud/automl_v1beta1/proto/operations_pb2.py
automl/google/cloud/automl_v1beta1/proto/prediction_service_pb2.py
automl/google/cloud/automl_v1beta1/proto/service_pb2.py
automl/google/cloud/automl_v1beta1/proto/text_pb2.py
...
vision/google/cloud/vision_v1p3beta1/proto/text_annotation_pb2.py
vision/google/cloud/vision_v1p3beta1/proto/web_detection_pb2.py
websecurityscanner/google/cloud/websecurityscanner_v1alpha/proto/crawled_url_pb2.py
websecurityscanner/google/cloud/websecurityscanner_v1alpha/proto/finding_addon_pb2.py
websecurityscanner/google/cloud/websecurityscanner_v1alpha/proto/finding_pb2.py
websecurityscanner/google/cloud/websecurityscanner_v1alpha/proto/finding_type_stats_pb2.py
websecurityscanner/google/cloud/websecurityscanner_v1alpha/proto/scan_config_pb2.py
websecurityscanner/google/cloud/websecurityscanner_v1alpha/proto/scan_run_pb2.py
websecurityscanner/google/cloud/websecurityscanner_v1alpha/proto/web_security_scanner_pb2.py
$ git grep -l "file=DESCRIPTOR" | cut -d "/" -f 1 | sort -u
asset
automl
bigquery_datatransfer
bigtable
container
dataproc
datastore
dlp
error_reporting
firestore
iot
kms
language
logging
monitoring
oslogin
pubsub
redis
securitycenter
spanner
speech
tasks
texttospeech
trace
videointelligence
vision
websecurityscanner

Those libs can only guarantee protobuf >= 3.4 by pinning google-api_core >= 1.4.1.

@tseaver
Copy link
Contributor Author

tseaver commented Nov 7, 2018

Unrelated flaky storage system test: see #6443.

@tseaver tseaver merged commit 1787742 into googleapis:master Nov 7, 2018
@tseaver tseaver deleted the 6390-datastore-bump_api_core_dependency branch November 7, 2018 19:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants