-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Speech generated samples #8210
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2019
Result of re-running synthtool In addition to ./include_samples.sh used to setup the samples/tests
If you delete samples/ and re-run with include_samples=True the exact samples/ structure will be regenerated (no git diff)
@beccasaurus Do you need anything from me, or is this mostly here for demonstration purposes? 😄 |
4 tasks
4 tasks
🧹 Out-of-date / Deprecated
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
api: speech
Issues related to the Speech-to-Text API.
cla: yes
This human has signed the Contributor License Agreement.
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add labels:
do not merge
api: speech
This PR is a companion to a similar PR sent for PHP: googleapis/google-cloud-php#1991
I send this Python PR to show differences between the generated PHP + Python sample artifacts.
I also sent a similar PR to Ruby: googleapis/google-cloud-ruby#3431
=> @dwsupplee
/cc @busunkim96
/fyi @TheRoyalTnetennba @dazuma @googleapis/samplegen
The following is the body of the PHP Pull Request (for context) –
Hello there, dear PHP friends! 🐘
We'd like to incorporate the samples which GAPIC generator now supports into
google-cloud-php
.tl;dr
These things are required to "Make it go"
samples/
directory by synth.py (gapic-generator
)samples/...
directory from googleapis (synthtool
)samples/...
directory from googleapis (synthtool
)google-cloud-php
)^ I need y'all's help with this last one!
More info: go/library-samples (internal)
End Goal
🤖 Autosynth sends PRs for new / modified code samples and tests
Should work once google-cloud-php is configured to run system tests for generated samples in CI ✨
This PR
This PR serves the purpose of being an example Pull Request with generated samples to use for CI setup.
The actual diff of this PR is a result of doing the following:
synth.py
to generate samples (currently opt-in feature behind a --dev_samples flag)Companion PRs
To help with discussion / see differences between a couple languages, I send PRs to Python and Ruby:
DIY
If you want to reproduce this diff:
google-cloud-php
and checkout fresh master and cd Speech/synth.py
to add sampless.copy(library / 'samples/')
and enable sample generation
--dev_samples
python3 -m synthtool
If you want to run the tests: