chore(pubsub): Add commit_proto_schema to samples #29241
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aandreassa
force-pushed
the
pubsub_commit_proto_schema
branch
5 times, most recently
from
77cf0a9 to
c6d1abf
Compare
aandreassa
force-pushed
the
pubsub_commit_proto_schema
branch
from
c6d1abf to
4bb6ef0
Compare
dazuma
requested changes
Feb 27, 2025
| def revision_id | ||
| return nil if reference? | ||
| @grpc.revision_id if @grpc.revision_id && !@grpc.revision_id.empty? | ||
| end |
There was a problem hiding this comment.
Note: these are functional changes to the library. If we include these, we'll need to apply the feat: conventional commit tag.
| ## | ||
| # The revision ID of the schema. | ||
| # | ||
| # @return [String] The revision id. |
There was a problem hiding this comment.
Need to document that this can also return nil. One way to do that is to have a second @return tag, e.g.
# @return [String] The revision id.
# @return [nil] If this object is a reference.
| def commit_proto_schema schema_id:, proto_file: | ||
| # [START pubsub_commit_proto_schema] | ||
| # schema_id = "your-schema-id" | ||
| # proto_file = "path/to/a/proto/file/(.proto)/formatted/in/protocol/buffers" |
There was a problem hiding this comment.
This is a little odd because the value is not a well-formed example path. How about just "path/to/a/proto_file.proto"?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.