Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

add PercentEscaperTest #957

Merged
merged 1 commit into from
Jan 24, 2020
Merged

add PercentEscaperTest #957

merged 1 commit into from
Jan 24, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jan 22, 2020

@frankyn I can't find any evidence that my previous change had an effect here.

@elharo elharo requested a review from frankyn January 22, 2020 21:43
@elharo elharo requested a review from a team as a code owner January 22, 2020 21:43
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 22, 2020
@frankyn
Copy link

frankyn commented Jan 22, 2020 •
edited
Loading

Followed-up through chat. You're right. I reverted your change locally and my tests still pass. The fix is already in master AFAICT. Apologies for the confusion.

elharo
elharo commented Jan 24, 2020
View reviewed changes
Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping. This one still needs a review.

@chingor13 chingor13 merged commit 8e31198 into master Jan 24, 2020
@chingor13 chingor13 deleted the perc branch January 24, 2020 18:27
@yoshi-automation yoshi-automation mentioned this pull request Feb 1, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

@frankyn frankyn frankyn approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elharo @frankyn @chingor13 @googlebot