Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

More work toward removing plusForSpace #961

Merged
merged 11 commits into from
Jan 28, 2020
Merged

More work toward removing plusForSpace #961

merged 11 commits into from
Jan 28, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jan 27, 2020

@elharo elharo requested a review from frankyn January 27, 2020 11:55
@elharo elharo requested a review from a team as a code owner January 27, 2020 11:55
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 27, 2020
frankyn
frankyn approved these changes Jan 28, 2020
View reviewed changes
Copy link

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given the changes are for internal values and methods only.

@elharo elharo closed this Jan 28, 2020
@elharo elharo reopened this Jan 28, 2020
@elharo elharo merged commit 67d5eb1 into master Jan 28, 2020
@elharo elharo deleted the escape branch January 28, 2020 17:24
@yoshi-automation yoshi-automation mentioned this pull request Feb 1, 2020
Merged
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
@renovate-bot
chore(deps): update dependency org.apache.maven.plugins:maven-site-pl…
0473f12 
…ugin to v3.12.1 (googleapis#961)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.apache.maven.plugins:maven-site-plugin](https://maven.apache.org/plugins/) | `3.12.0` -> `3.12.1` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-site-plugin/3.12.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-site-plugin/3.12.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-site-plugin/3.12.1/compatibility-slim/3.12.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-site-plugin/3.12.1/confidence-slim/3.12.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNDMuMSIsInVwZGF0ZWRJblZlciI6IjMyLjE0My4xIn0=-->
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@frankyn frankyn frankyn approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elharo @frankyn @googlebot