Skip to content

docs: Expand hello world snippet to show how to access specific cells #516

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2020
Merged

docs: Expand hello world snippet to show how to access specific cells #516

merged 2 commits into from
Dec 21, 2020

Conversation

dmitry-fa
Copy link
Contributor

Fixes #473

@dmitry-fa dmitry-fa requested a review from a team November 9, 2020 13:40
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2020
@snippet-bot
Copy link

snippet-bot bot commented Nov 9, 2020 •
edited
Loading

Here is the summary of changes.

You added 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Nov 9, 2020
@dmitry-fa dmitry-fa changed the title Snippet helloworld samples: Expand hello world snippet to show how to access specific cells Nov 9, 2020
@codecov
Copy link

codecov bot commented Nov 9, 2020 •
edited
Loading

Codecov Report

Merging #516 (22d482a) into master (45535c4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #516   +/-   ##
=========================================
  Coverage     81.31%   81.31%           
  Complexity     1128     1128           
=========================================
  Files           106      106           
  Lines          7042     7042           
  Branches        368      368           
=========================================
  Hits           5726     5726           
  Misses         1119     1119           
  Partials        197      197

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45535c4...22d482a. Read the comment docs.

@dmitry-fa
Copy link
Contributor Author

Questions/comments which arose in the process of handling this issue:

  • There is no documentation on how to build samples. I used the following command:
#> cd samples/snippets
#> GOOGLE_CLOUD_PROJECT=my-project BIGTABLE_TESTING_INSTANCE=my-insntance mvn clean verify
  • All tests pass except one: Quickstart, which expects a certain table to exist
  • A number of tests produce:
io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference cleanQueue
SEVERE: *~*~*~ Channel ManagedChannelImpl{logId=7, target=bigtableadmin.googleapis.com:443} was not shutdown properly!!! ~*~*~*

currently fixed for HelloWorld only. Should it be fixed for other tests?

  • Formatter could be used to clean up the coding style

@kolea2 kolea2 requested a review from billyjacobson November 9, 2020 18:00
billyjacobson
billyjacobson approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@billyjacobson billyjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great and thanks for getting tests added

@kolea2 kolea2 mentioned this pull request Nov 13, 2020
Closed
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 16, 2020
@eaball35
Copy link
Contributor

Screen Shot 2020-12-16 at 9 27 53 AM

@igorbernstein2 igorbernstein2 changed the title samples: Expand hello world snippet to show how to access specific cells docs: Expand hello world snippet to show how to access specific cells Dec 17, 2020
igorbernstein2
igorbernstein2 approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@igorbernstein2
Copy link
Contributor

@kolea2 I think this requires your approval

@dmitry-fa
Copy link
Contributor Author

@kolea2 gentle ping

@kolea2 kolea2 merged commit a9001a8 into googleapis:master Dec 21, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 8, 2021
@release-please
chore(master): release 1.20.0 (#610)
9cc505f 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.20.0](https://github.com/googleapis/java-bigtable/compare/v1.19.2...v1.20.0) (2021-02-05)


### Features

* Surface the server-timing metric ([#535](https://github.com/googleapis/java-bigtable/issues/535)) ([8240779](https://github.com/googleapis/java-bigtable/commit/8240779434a602dc8b2bf90dbe539c5d7470d850))


### Bug Fixes

* fix MetricTracerTest to rebase on head ([#581](https://github.com/googleapis/java-bigtable/issues/581)) ([23e97cb](https://github.com/googleapis/java-bigtable/commit/23e97cb308403b35fbe972b08048d0e59423e694))
* fix MutateRowsAttemptCallable to avoid NPE in MetricTracer ([#557](https://github.com/googleapis/java-bigtable/issues/557)) ([8d71020](https://github.com/googleapis/java-bigtable/commit/8d7102003b54757b64fd598290301d3b24fd9c29))
* Retry "received rst stream" ([#586](https://github.com/googleapis/java-bigtable/issues/586)) ([b09a21c](https://github.com/googleapis/java-bigtable/commit/b09a21c1dd1a05b68bfd3a0134089ba32dca1774))
* update repo name ([#615](https://github.com/googleapis/java-bigtable/issues/615)) ([bb3ed6d](https://github.com/googleapis/java-bigtable/commit/bb3ed6dcbadbd70dbd9c68152c8d93c4cefd4dcb))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.17.1 ([#590](https://github.com/googleapis/java-bigtable/issues/590)) ([5035ad0](https://github.com/googleapis/java-bigtable/commit/5035ad0db01a9247634137050698c30da29722a6))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.18.0 ([#592](https://github.com/googleapis/java-bigtable/issues/592)) ([c58b73a](https://github.com/googleapis/java-bigtable/commit/c58b73a7d70c8da1581ac06d77b5e362648a0868))
* update dependency com.google.errorprone:error_prone_annotations to v2.5.0 ([#591](https://github.com/googleapis/java-bigtable/issues/591)) ([dfa4da7](https://github.com/googleapis/java-bigtable/commit/dfa4da75e5ac81cc941177462326f7c38f18bacd))
* update dependency com.google.errorprone:error_prone_annotations to v2.5.1 ([#594](https://github.com/googleapis/java-bigtable/issues/594)) ([ea599a1](https://github.com/googleapis/java-bigtable/commit/ea599a10e2e4fdbaf56c45b74fbb1ea5a708a7f2))


### Documentation

* Expand hello world snippet to show how to access specific cells ([#516](https://github.com/googleapis/java-bigtable/issues/516)) ([a9001a8](https://github.com/googleapis/java-bigtable/commit/a9001a88f338fc2acf6bc48927765f29819124ee))
* Update stackdriver examples for tracing and stats ([#613](https://github.com/googleapis/java-bigtable/issues/613)) ([3e8af74](https://github.com/googleapis/java-bigtable/commit/3e8af747b329f6656a410160e8da14fd8227c8fc))
* use autogenerated readme functionality and regenerate ([#568](https://github.com/googleapis/java-bigtable/issues/568)) ([844e5be](https://github.com/googleapis/java-bigtable/commit/844e5beb6230df6ca220935056aae7f6e73d2bc0))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ad548 pushed a commit to ad548/java-bigtable that referenced this pull request Mar 13, 2021
@dmitry-fa @ad548
docs: Expand hello world snippet to show how to access specific cells (…
63e6624 
…googleapis#516)

* samples: Expand hello world snippet to show how to access specific cells by family & qualifier

* samples: Expand hello world snippet to show how to access specific cells by family & qualifier
ad548 pushed a commit to ad548/java-bigtable that referenced this pull request Mar 13, 2021
@release-please @ad548
chore(master): release 1.20.0 (googleapis#610)
9b5f460 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.20.0](https://github.com/googleapis/java-bigtable/compare/v1.19.2...v1.20.0) (2021-02-05)


### Features

* Surface the server-timing metric ([googleapis#535](https://github.com/googleapis/java-bigtable/issues/535)) ([8240779](https://github.com/googleapis/java-bigtable/commit/8240779434a602dc8b2bf90dbe539c5d7470d850))


### Bug Fixes

* fix MetricTracerTest to rebase on head ([googleapis#581](https://github.com/googleapis/java-bigtable/issues/581)) ([23e97cb](https://github.com/googleapis/java-bigtable/commit/23e97cb308403b35fbe972b08048d0e59423e694))
* fix MutateRowsAttemptCallable to avoid NPE in MetricTracer ([googleapis#557](https://github.com/googleapis/java-bigtable/issues/557)) ([8d71020](https://github.com/googleapis/java-bigtable/commit/8d7102003b54757b64fd598290301d3b24fd9c29))
* Retry "received rst stream" ([googleapis#586](https://github.com/googleapis/java-bigtable/issues/586)) ([b09a21c](https://github.com/googleapis/java-bigtable/commit/b09a21c1dd1a05b68bfd3a0134089ba32dca1774))
* update repo name ([googleapis#615](https://github.com/googleapis/java-bigtable/issues/615)) ([bb3ed6d](https://github.com/googleapis/java-bigtable/commit/bb3ed6dcbadbd70dbd9c68152c8d93c4cefd4dcb))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.17.1 ([googleapis#590](https://github.com/googleapis/java-bigtable/issues/590)) ([5035ad0](https://github.com/googleapis/java-bigtable/commit/5035ad0db01a9247634137050698c30da29722a6))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.18.0 ([googleapis#592](https://github.com/googleapis/java-bigtable/issues/592)) ([c58b73a](https://github.com/googleapis/java-bigtable/commit/c58b73a7d70c8da1581ac06d77b5e362648a0868))
* update dependency com.google.errorprone:error_prone_annotations to v2.5.0 ([googleapis#591](https://github.com/googleapis/java-bigtable/issues/591)) ([dfa4da7](https://github.com/googleapis/java-bigtable/commit/dfa4da75e5ac81cc941177462326f7c38f18bacd))
* update dependency com.google.errorprone:error_prone_annotations to v2.5.1 ([googleapis#594](https://github.com/googleapis/java-bigtable/issues/594)) ([ea599a1](https://github.com/googleapis/java-bigtable/commit/ea599a10e2e4fdbaf56c45b74fbb1ea5a708a7f2))


### Documentation

* Expand hello world snippet to show how to access specific cells ([googleapis#516](https://github.com/googleapis/java-bigtable/issues/516)) ([a9001a8](https://github.com/googleapis/java-bigtable/commit/a9001a88f338fc2acf6bc48927765f29819124ee))
* Update stackdriver examples for tracing and stats ([googleapis#613](https://github.com/googleapis/java-bigtable/issues/613)) ([3e8af74](https://github.com/googleapis/java-bigtable/commit/3e8af747b329f6656a410160e8da14fd8227c8fc))
* use autogenerated readme functionality and regenerate ([googleapis#568](https://github.com/googleapis/java-bigtable/issues/568)) ([844e5be](https://github.com/googleapis/java-bigtable/commit/844e5beb6230df6ca220935056aae7f6e73d2bc0))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@billyjacobson billyjacobson billyjacobson approved these changes

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

@kolea2 kolea2 kolea2 approved these changes

Assignees

@kolea2 kolea2

Labels
api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand hello world snippet to show how to access specific cells by family & qualifier
5 participants
@dmitry-fa @eaball35 @igorbernstein2 @billyjacobson @kolea2