-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: filter limit constant #787
Conversation
Should 20 KB not 20 MB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the test also needs to be updated:
[INFO] Running com.google.cloud.bigtable.data.v2.models.QueryTest
Error: Tests run: 13, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.579 s <<< FAILURE! - in com.google.cloud.bigtable.data.v2.models.QueryTest
Error: com.google.cloud.bigtable.data.v2.models.QueryTest.filterTestWithExceptions Time elapsed: 0.563 s <<< FAILURE!
value of : throwable.getMessage()
expected to contain: filter size can't be more than 20MB
but was : filter size can't be more than 20KB
at com.google.cloud.bigtable.data.v2.models.QueryTest.filterTestWithExceptions(QueryTest.java:134)
Caused by: java.lang.IllegalArgumentException: filter size can't be more than 20KB
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:144)
at com.google.cloud.bigtable.data.v2.models.Query.filter(Query.java:172)
Codecov Report
@@ Coverage Diff @@
## master #787 +/- ##
============================================
+ Coverage 83.44% 83.49% +0.05%
- Complexity 1311 1315 +4
============================================
Files 114 114
Lines 7799 7806 +7
Branches 442 446 +4
============================================
+ Hits 6508 6518 +10
+ Misses 1036 1033 -3
Partials 255 255
Continue to review full report at Codecov.
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
🤖 I have created a release \*beep\* \*boop\* --- ### [1.24.1](https://github.com/googleapis/java-bigtable/compare/v1.24.0...v1.24.1) (2021-05-11) ### Bug Fixes * filter limit constant ([#787](https://github.com/googleapis/java-bigtable/issues/787)) ([04f8ad4](https://github.com/googleapis/java-bigtable/commit/04f8ad463d1fa9efe0ab941ee5f3d0794baed814)) * fix flaky test ([#798](https://github.com/googleapis/java-bigtable/issues/798)) ([83e0e8c](https://github.com/googleapis/java-bigtable/commit/83e0e8cf2cdbc143c10ce0f8b053096d61d5686f)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v1.1.0 ([#805](https://github.com/googleapis/java-bigtable/issues/805)) ([a498687](https://github.com/googleapis/java-bigtable/commit/a498687d15dd9af35c57b0df6d08c87ef36833da)) ### Documentation * update the comments in Cloud Bigtable RestoreTable API to reflect the new API capability ([#804](https://github.com/googleapis/java-bigtable/issues/804)) ([f5e5d5a](https://github.com/googleapis/java-bigtable/commit/f5e5d5ac196529d5b070ef5fd8118038fec2e2de)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
* fix: filter limit constant Should 20 KB not 20 MB * fix test (cherry picked from commit 04f8ad4)
🤖 I have created a release \*beep\* \*boop\* --- ## [1.22.0-sp.1](https://github.com/googleapis/java-bigtable/compare/1.22.0...v1.22.0-sp.1) (2021-05-21) ### Features * configure initial sp version ([#829](https://github.com/googleapis/java-bigtable/issues/829)) ([47480c5](https://github.com/googleapis/java-bigtable/commit/47480c55ab08b80154a4a7d2bb76a9dccfcdea03)) ### Bug Fixes * filter limit constant ([#787](https://github.com/googleapis/java-bigtable/issues/787)) ([#835](https://github.com/googleapis/java-bigtable/issues/835)) ([cf16cfe](https://github.com/googleapis/java-bigtable/commit/cf16cfe5ee1ec509ed8faf3ff1342bd02a041468)) * improve embedded version handling ([#715](https://github.com/googleapis/java-bigtable/issues/715)) ([#832](https://github.com/googleapis/java-bigtable/issues/832)) ([f0fc1bf](https://github.com/googleapis/java-bigtable/commit/f0fc1bf77962ddc80bfd5aca6a8ca731641d940b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Should be 20 KB not 20 MB
https://cloud.google.com/bigtable/quotas#row-filters