Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: fix Java 17 build. No wildcard import. #86

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Nov 24, 2021

The Java 17 build of this repository has been failing. For example #85 (comment)

[INFO] -------------------------------------------------------------
Error:  COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
Error:  /home/runner/work/java-pubsublite-flink/java-pubsublite-flink/src/main/java/com/google/cloud/pubsublite/flink/PubsubLiteSourceSettings.java:[171,23] error: reference to Record is ambiguous
  both class com.google.cloud.pubsublite.flink.internal.reader.Record in com.google.cloud.pubsublite.flink.internal.reader and class java.lang.Record in java.lang match

PubsubLiteSourceSettings was using wildcard import statements that
broke Java 17 build due to the ambiguity with java.lang.Record.

PubsubLiteSourceSettings was using wildcard import statements that
broke Java 17 build due to the ambiguity with java.lang.Record.
@suztomo suztomo requested a review from a team as a code owner November 24, 2021 15:59
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 24, 2021
@suztomo suztomo requested a review from a team November 24, 2021 16:04
@suztomo
Copy link
Member Author

suztomo commented Nov 24, 2021

@dpcollins-google It requires code owner review. Can you check this?

@dpcollins-google dpcollins-google merged commit 9102c5f into googleapis:main Nov 29, 2021
@suztomo suztomo deleted the fix_java17 branch November 29, 2021 17:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants