-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Storage#update always removes all lifecycle rules if they are not specified #850
Labels
api: storage
Issues related to the googleapis/java-storage API.
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
Thanks for reporting this, the fix is included in #852 and will go out in the next release. |
BenWhitehead
added a commit
that referenced
this issue
Jun 1, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
Jun 1, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.115.0](https://github.com/googleapis/java-storage/compare/v1.114.0...v1.115.0) (2021-06-01) ### Features * add `gcf-owl-bot[bot]` to `ignoreAuthors` ([#837](https://github.com/googleapis/java-storage/issues/837)) ([fe8e98a](https://github.com/googleapis/java-storage/commit/fe8e98a229f472c1f29d206d937690660bfa1444)) ### Bug Fixes * improve error detection and reporting for BlobWriteChannel retry state ([#846](https://github.com/googleapis/java-storage/issues/846)) ([d0f2184](https://github.com/googleapis/java-storage/commit/d0f2184f4dd2d99a4315f260f35421358d14a2df)), closes [#839](https://github.com/googleapis/java-storage/issues/839) * update BucketInfo translation code to properly handle lifecycle rules ([#852](https://github.com/googleapis/java-storage/issues/852)) ([3b1df1d](https://github.com/googleapis/java-storage/commit/3b1df1d00a459b134103bc8738f0294188502a37)), closes [#850](https://github.com/googleapis/java-storage/issues/850) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v1.2.0 ([#836](https://github.com/googleapis/java-storage/issues/836)) ([c1752ce](https://github.com/googleapis/java-storage/commit/c1752ce17d5d723d0ea36c41d98ae2bc9201fec2)) * update kms.version to v0.88.4 ([#830](https://github.com/googleapis/java-storage/issues/830)) ([7e3dc28](https://github.com/googleapis/java-storage/commit/7e3dc287e4285a9312393179671a78c569e7e869)) * update kms.version to v0.89.0 ([#855](https://github.com/googleapis/java-storage/issues/855)) ([29236e9](https://github.com/googleapis/java-storage/commit/29236e9d2eefb0e64b1b9bbfc532f4c3ae3e9ea4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
BenWhitehead
added a commit
that referenced
this issue
Sep 28, 2021
* feat: Remove client side vaildation for lifecycle conditions (#816) * Remove client side vaildation for lifecycle conditions * fix lint and suggest updating (cherry picked from commit 5ec84cc) * fix: update BucketInfo translation code to properly handle lifecycle rules (#852) Fixes #850 (cherry picked from commit 3b1df1d) * fix: improve error detection and reporting for BlobWriteChannel retry state (#846) Add new checks to ensure a more informative error than NullPointerException is thrown if the StorageObject or it's size are unable to be resolved on the last chunk. Fixes #839 (cherry picked from commit d0f2184) * fix: correct lastChunk retry logic in BlobWriteChannel (#918) Add new method StorageRpc#queryResumableUpload which allows getting a shallow StorageObject for a resumable upload session which is complete. Update BlobWriteChannel to use StoageRpc#queryResumableUpload instead of StorageRpc#get when attempting to validate the upload size of an object when it determines the upload is complete and is on the last chunk. If a BlobWriteChannel is opened with a conditional like IfGenerationMatch it is not possible to simply get the object, as the object can drift generationally while the resumable upload is being performed. Related to #839 (cherry picked from commit ab0228c) * test: remove error string matching (#861) It looks like the text for this error on the backend has changed (sometimes) from "Precondition Failed" to "At least one of the pre-conditions you specified did not hold". I don't think it's really necessary to check the exact message in any case given that we do check for a code of 412, which implies a precondition failure. I added a check of the error Reason instead, which is more standardized. Fixes #853 (cherry picked from commit 146a3d3) Co-authored-by: JesseLovelace <43148100+JesseLovelace@users.noreply.github.com> Co-authored-by: Chris Cotter <cjcotter@google.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
api: storage
Issues related to the googleapis/java-storage API.
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Issue with
com.google.cloud.storage.Storage#update(com.google.cloud.storage.BucketInfo, com.google.cloud.storage.Storage.BucketTargetOption...)
Expected behaviour:
update only fields that are specified in
BucketInfo
parameter.Actual behaviour:
along the updated fields, removes lifecycle rules if they are not specified.
Example code:
Actual output (for bucket with 1 lifecycle rule):
I suspect that issue is located here:
java-storage/google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java
Lines 1841 to 1869 in accf502
The text was updated successfully, but these errors were encountered: