Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert "feat: add upload functionality" #224

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Conversation

frankyn
Copy link
Contributor

@frankyn frankyn commented Apr 2, 2020

Reverts #214

Let's revert this and talk through it more before we finalize and merge again.

Once we release this change we will end with having to support it long term. I want a solution quickly but don't want to create friction.

Thank you for your patience.

@frankyn frankyn requested a review from dmitry-fa April 2, 2020 08:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 2, 2020
@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #224 into master will decrease coverage by 0.17%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #224      +/-   ##
============================================
- Coverage     63.67%   63.50%   -0.18%     
+ Complexity      548      540       -8     
============================================
  Files            31       30       -1     
  Lines          4782     4762      -20     
  Branches        428      427       -1     
============================================
- Hits           3045     3024      -21     
- Misses         1577     1578       +1     
  Partials        160      160              
Impacted Files Coverage Δ Complexity Δ
...e/src/main/java/com/google/cloud/storage/Blob.java 81.97% <91.66%> (-0.28%) 29.00 <0.00> (ø)
...va/com/google/cloud/storage/StorageOperations.java

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5599f29...c1deda2. Read the comment docs.

Copy link
Contributor

@dmitry-fa dmitry-fa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@dmitry-fa dmitry-fa added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2020
@dmitry-fa
Copy link
Contributor

@frankyn Integration test fails: com.google.cloud.storage.StorageException: The project exceeded the rate limit for creating and deleting buckets.

@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2020
@frankyn frankyn merged commit e87c731 into master Apr 2, 2020
@frankyn frankyn deleted the revert-214-storageUtils branch April 2, 2020 20:09
@release-please release-please bot mentioned this pull request Apr 2, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants