Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add support of public access prevention #636

Merged
merged 22 commits into from
Jun 28, 2021

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Nov 26, 2020

Fixes #616

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Nov 26, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 26, 2020
@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #636 (37e19e3) into master (1dfcc02) will increase coverage by 0.11%.
The diff coverage is 88.00%.

❗ Current head 37e19e3 differs from pull request most recent head ec75bb2. Consider uploading reports for the commit ec75bb2 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #636      +/-   ##
============================================
+ Coverage     64.62%   64.73%   +0.11%     
  Complexity      634      634              
============================================
  Files            32       32              
  Lines          5314     5337      +23     
  Branches        519      522       +3     
============================================
+ Hits           3434     3455      +21     
- Misses         1718     1719       +1     
- Partials        162      163       +1     
Impacted Files Coverage Δ
...main/java/com/google/cloud/storage/BucketInfo.java 84.24% <88.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fad4a31...ec75bb2. Read the comment docs.

@athakor
Copy link
Contributor Author

athakor commented Nov 26, 2020

@shaffeeullah @tritone

@athakor athakor added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Nov 27, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 27, 2020
@elharo
Copy link
Contributor

elharo commented Dec 4, 2020

Dec 03, 2020 7:29:41 AM com.google.cloud.tools.dependencies.linkagemonitor.LinkageMonitor run
SEVERE: Newly introduced problems:
(com.google.apis:google-api-services-storage:v1-rev20200927-1.30.10) com.google.api.services.storage.model.Bucket$IamConfiguration's method setPublicAccessPrevention(String) is not found
  referenced from com.google.cloud.storage.BucketInfo (com.google.cloud:google-cloud-storage:1.113.5-SNAPSHOT)
(com.google.apis:google-api-services-storage:v1-rev20200927-1.30.10) com.google.api.services.storage.model.Bucket$IamConfiguration's method getPublicAccessPrevention() is not found
  referenced from com.google.cloud.storage.BucketInfo (com.google.cloud:google-cloud-storage:1.113.5-SNAPSHOT)

com.google.apis:google-api-services-storage:v1-rev20200927-1.30.10 is at:
  com.google.cloud:google-cloud-nio:0.122.1 (compile) / com.google.apis:google-api-services-storage:v1-rev20200927-1.30.10 (compile)
  and 2 other dependency paths.
com.google.cloud:google-cloud-storage:1.113.5-SNAPSHOT is at:
  com.google.cloud:google-cloud-storage:1.113.5-SNAPSHOT (compile)

@frankyn
Copy link
Contributor

frankyn commented Dec 4, 2020

For the linker issues, we need to cut a new release of storage with the updated Apiary client (#613) and a new release of libraries-bom as well.

@tritone tritone marked this pull request as ready for review December 11, 2020 00:45
@tritone tritone requested a review from a team December 11, 2020 00:45
@tritone
Copy link
Contributor

tritone commented Dec 11, 2020

For the linker issues, we need to cut a new release of storage with the updated Apiary client (#613) and a new release of libraries-bom as well.

Looks like this has been completed. @athakor can you merge in master?

@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 11, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 11, 2020
@athakor
Copy link
Contributor Author

athakor commented Dec 11, 2020

For the linker issues, we need to cut a new release of storage with the updated Apiary client (#613) and a new release of libraries-bom as well.

Looks like this has been completed. @athakor can you merge in master?

done.. Still linker issue

@frankyn frankyn self-requested a review December 11, 2020 16:54
@athakor athakor requested review from frankyn and tritone December 21, 2020 13:35
@athakor athakor requested a review from a team December 31, 2020 08:27
@frankyn frankyn dismissed their stale review March 10, 2021 00:47

I'm now running point as co-author

@frankyn frankyn removed their request for review March 10, 2021 00:48
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenWhitehead can you take a look when you have a moment?

Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple new nits, and the outstanding valueOf call

frankyn and others added 2 commits March 11, 2021 22:07
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
@frankyn frankyn requested a review from BenWhitehead March 22, 2021 16:44
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2021
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing this up Ben!

Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a lint failure; otherwise LGTM

@shaffeeullah
Copy link

shaffeeullah commented Jun 8, 2021

@BenWhitehead & @frankyn ,

We would like to merge and release this feature next Monday (06/14/21). Does that work for you? Do one of you have bandwidth this week to resolve the conflicts? Sorry, I know this PR has been open for a while.

@snippet-bot
Copy link

snippet-bot bot commented Jun 10, 2021

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 10, 2021
@shaffeeullah
Copy link

Public access prevention rollout has been delayed due to a bug surfaced during Googler preview. I will keep this PR updated as I learn new release timeline details.

@frankyn frankyn added the status: blocked Resolving the issue is dependent on other work. label Jun 11, 2021
@BenWhitehead BenWhitehead added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 14, 2021
@shaffeeullah
Copy link

@BenWhitehead This feature can now be merged and released.

@BenWhitehead BenWhitehead removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. labels Jun 28, 2021
@BenWhitehead BenWhitehead merged commit 3d1e482 into googleapis:master Jun 28, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 28, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [1.117.0](https://github.com/googleapis/java-storage/compare/v1.116.0...v1.117.0) (2021-06-28)


### Features

* Add from and to storage url options for BlobId ([#888](https://github.com/googleapis/java-storage/issues/888)) ([1876a58](https://github.com/googleapis/java-storage/commit/1876a580f904d095ca6621c1e2f38c3a6e253276))
* add support of public access prevention ([#636](https://github.com/googleapis/java-storage/issues/636)) ([3d1e482](https://github.com/googleapis/java-storage/commit/3d1e48208c44c35c8e3761913bcd05c438e81069))


### Bug Fixes

* Add `shopt -s nullglob` to dependencies script ([#894](https://github.com/googleapis/java-storage/issues/894)) ([901fd33](https://github.com/googleapis/java-storage/commit/901fd335c8d2f2e49844dee2adfa318a98ed99ba))
* Update dependencies.sh to not break on mac ([#879](https://github.com/googleapis/java-storage/issues/879)) ([bc6d1d9](https://github.com/googleapis/java-storage/commit/bc6d1d9e211fbbb1accd1019c8eed4bc55ca421c))


### Documentation

* add notice about broken OLM experience ([#898](https://github.com/googleapis/java-storage/issues/898)) ([73e7cdf](https://github.com/googleapis/java-storage/commit/73e7cdf162be76a8438160f4c7f2070fb6fb5ea6))


### Dependencies

* update dependency com.google.apis:google-api-services-storage to v1-rev20210127-1.31.5 ([#889](https://github.com/googleapis/java-storage/issues/889)) ([99138a4](https://github.com/googleapis/java-storage/commit/99138a4cd3523cc634e3c5283a775a1c245b6201))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
api: storage Issues related to the googleapis/java-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for PublicAccessPrevention
7 participants