-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add support of public access prevention #636
Conversation
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
============================================
+ Coverage 64.62% 64.73% +0.11%
Complexity 634 634
============================================
Files 32 32
Lines 5314 5337 +23
Branches 519 522 +3
============================================
+ Hits 3434 3455 +21
- Misses 1718 1719 +1
- Partials 162 163 +1
Continue to review full report at Codecov.
|
google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/test/java/com/google/cloud/storage/BucketInfoTest.java
Outdated
Show resolved
Hide resolved
|
For the linker issues, we need to cut a new release of storage with the updated Apiary client (#613) and a new release of libraries-bom as well. |
google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenWhitehead can you take a look when you have a moment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple new nits, and the outstanding valueOf call
google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java
Outdated
Show resolved
Hide resolved
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for fixing this up Ben!
google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is a lint failure; otherwise LGTM
…zed value when set to UNKNOWN
We would like to merge and release this feature next Monday (06/14/21). Does that work for you? Do one of you have bandwidth this week to resolve the conflicts? Sorry, I know this PR has been open for a while. |
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
Public access prevention rollout has been delayed due to a bug surfaced during Googler preview. I will keep this PR updated as I learn new release timeline details. |
@BenWhitehead This feature can now be merged and released. |
🤖 I have created a release \*beep\* \*boop\* --- ## [1.117.0](https://github.com/googleapis/java-storage/compare/v1.116.0...v1.117.0) (2021-06-28) ### Features * Add from and to storage url options for BlobId ([#888](https://github.com/googleapis/java-storage/issues/888)) ([1876a58](https://github.com/googleapis/java-storage/commit/1876a580f904d095ca6621c1e2f38c3a6e253276)) * add support of public access prevention ([#636](https://github.com/googleapis/java-storage/issues/636)) ([3d1e482](https://github.com/googleapis/java-storage/commit/3d1e48208c44c35c8e3761913bcd05c438e81069)) ### Bug Fixes * Add `shopt -s nullglob` to dependencies script ([#894](https://github.com/googleapis/java-storage/issues/894)) ([901fd33](https://github.com/googleapis/java-storage/commit/901fd335c8d2f2e49844dee2adfa318a98ed99ba)) * Update dependencies.sh to not break on mac ([#879](https://github.com/googleapis/java-storage/issues/879)) ([bc6d1d9](https://github.com/googleapis/java-storage/commit/bc6d1d9e211fbbb1accd1019c8eed4bc55ca421c)) ### Documentation * add notice about broken OLM experience ([#898](https://github.com/googleapis/java-storage/issues/898)) ([73e7cdf](https://github.com/googleapis/java-storage/commit/73e7cdf162be76a8438160f4c7f2070fb6fb5ea6)) ### Dependencies * update dependency com.google.apis:google-api-services-storage to v1-rev20210127-1.31.5 ([#889](https://github.com/googleapis/java-storage/issues/889)) ([99138a4](https://github.com/googleapis/java-storage/commit/99138a4cd3523cc634e3c5283a775a1c245b6201)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Fixes #616