Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor streaming of table rows and remove through2 dependency #708

Closed
crwilcox opened this issue Apr 15, 2020 · 1 comment
Closed

Refactor streaming of table rows and remove through2 dependency #708

crwilcox opened this issue Apr 15, 2020 · 1 comment
Assignees
@crwilcox
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@crwilcox
Copy link
Contributor

The code for table.ts is a bit complicated and can likely be streamlined. In order to retry, we nest two streams.

It is likely worth removing the two instances of through and subclassing stream. This should help to shutdown on termination and not attempt writes past that point.

This also will remove dependencies on through2 and readable-stream
@crwilcox crwilcox added priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like. labels Apr 15, 2020
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/nodejs-bigtable API. label Apr 15, 2020
This was referenced Apr 15, 2020
Merged
Closed
@laljikanjareeya laljikanjareeya mentioned this issue Jul 9, 2020
Closed
1 task
@laljikanjareeya laljikanjareeya mentioned this issue Jul 20, 2020
Merged
@crwilcox
Copy link
Contributor Author

crwilcox commented Sep 4, 2020

#770 removed the remaining usage. 🎉

@crwilcox crwilcox closed this as completed Sep 4, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@crwilcox crwilcox

Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crwilcox