fix(deps): update dependency @google-cloud/common to v3 and handle stream ending #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
co-authored by: bcoe <bencoe@google.com>
googlebot
added
the
cla: yes
crwilcox
changed the title
crwilcox
changed the title
Codecov Report
@@ Coverage Diff @@
## master #704 +/- ##
==========================================
- Coverage 99.01% 98.99% -0.03%
==========================================
Files 15 15
Lines 15286 15289 +3
Branches 935 932 -3
==========================================
- Hits 15136 15135 -1
- Misses 147 151 +4
Partials 3 3
Continue to review full report at Codecov.
|
1 task
bcoe
reviewed
Apr 15, 2020
JustinBeckwith
approved these changes
Apr 15, 2020
|
#708 made to make sure we remember we may want to simplify some of this. |
bcoe
added
kokoro:force-run
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
co-authored by: @bcoe
#678 fails system tests due to a change in pumpify/readable streams. Changes to which tick things are cleaned up on seems to have surfaced an unpiping issue.