Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: remove through2 dependency #770

Merged

Conversation

laljikanjareeya
Copy link
Contributor

Towards #708

@laljikanjareeya laljikanjareeya requested a review from a team as a code owner July 20, 2020 06:46
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2020
@laljikanjareeya laljikanjareeya added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2020
@laljikanjareeya laljikanjareeya force-pushed the remove-throught2-dependency branch from 0817dbe to b5a7eb1 Compare July 21, 2020 07:31
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #770 into master will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
+ Coverage   98.85%   99.13%   +0.27%     
==========================================
  Files          17       17              
  Lines       15769    15774       +5     
  Branches      952      951       -1     
==========================================
+ Hits        15589    15638      +49     
+ Misses        176      133      -43     
+ Partials        4        3       -1     
Impacted Files Coverage Δ
src/table.ts 99.63% <100.00%> (+<0.01%) ⬆️
src/mutation.ts 100.00% <0.00%> (+0.23%) ⬆️
src/v2/bigtable_instance_admin_client.ts 98.78% <0.00%> (+0.65%) ⬆️
src/v2/bigtable_table_admin_client.ts 98.95% <0.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d046b5...d71de01. Read the comment docs.

@laljikanjareeya
Copy link
Contributor Author

@stephenplusplus Thanks for the review.

Two tests were failing:

  1. invalid - duplicate row key
  2. invalid - new row missing row key

I have also cross verify it with through2 version 4.0.2 these tests are also failing as they have removed destroy().
Based on that I just change the test cases.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants