Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: enable channel pooling #1065

Merged
merged 8 commits into from
Apr 6, 2022

Conversation

igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Apr 6, 2022

This is a continuation of #1062

This enables the channel pool from grpc-gcp-node and configures it to have 2-4 channels and also enables encrypted gfe headers every 10 mins. The results of the headers can be viewed by enabling verbose grpc logs (GRPC_TRACE=all GRPC_VERBOSITY=debug), however they can only be decrypted by google engineers

@igorbernstein2 igorbernstein2 requested review from a team as code owners April 6, 2022 17:47
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/nodejs-bigtable API. labels Apr 6, 2022
@igorbernstein2 igorbernstein2 changed the title Channel pool feat: enable channel pooling Apr 6, 2022
@igorbernstein2 igorbernstein2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 6, 2022
…he channel pool on data connection. And improve error reporting for pack n play
@googleapis googleapis deleted a comment from nimf Apr 6, 2022
@igorbernstein2 igorbernstein2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 6, 2022
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 6, 2022
@danieljbruce danieljbruce added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 6, 2022
Copy link
Contributor

@danieljbruce danieljbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@nimf nimf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorbernstein2 igorbernstein2 merged commit 6c3c397 into googleapis:main Apr 6, 2022
@igorbernstein2 igorbernstein2 deleted the channel-pool branch April 6, 2022 21:29
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 6, 2022
🤖 I have created a release *beep* *boop*
---


## [3.10.0](v3.9.4...v3.10.0) (2022-04-06)


### Features

* Add ListHotTablets API method and protobufs ([#1057](#1057)) ([2b175ac](2b175ac))
* AuditConfig for IAM v1 ([#1061](#1061)) ([d1b5f1a](d1b5f1a))
* enable channel pooling ([#1065](#1065)) ([6c3c397](6c3c397))


### Bug Fixes

* disable retry-request, add exponential backoff in mutateRows and readRows ([#1060](#1060)) ([3718011](3718011))
* retry rst_stream errors ([#1059](#1059)) ([90de80f](90de80f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants