Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add operation #1145

Merged
merged 4 commits into from
Aug 26, 2022
Merged

fix: add operation #1145

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb98b6c
add operation
danieljbruce Aug 25, 2022
71f8249
fix: add operation
danieljbruce Aug 25, 2022
8fe12e9
Merge branch 'main' of https://github.com/googleapis/nodejs-bigtable …
danieljbruce Aug 26, 2022
1f05b9d
Merge branch 'update-create-instance-sample' of https://github.com/da…
danieljbruce Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions samples/instances.js
View file
Original file line number Diff line number Diff line change
@@ -47,7 +47,8 @@ async function runInstanceOperations(instanceID, clusterID) {
};

// Create production instance with given options
const [prodInstance] = await instance.create(instanceOptions);
const [prodInstance, operation] = await instance.create(instanceOptions);
await operation.promise();
console.log(`Created Instance: ${prodInstance.id}`);
// [END bigtable_create_prod_instance]
} else {
@@ -105,7 +106,11 @@ async function createDevInstance(instanceID, clusterID) {
};

// Create development instance with given options
const [instance] = await bigtable.createInstance(instanceID, options);
const [instance, operation] = await bigtable.createInstance(
instanceID,
options
);
await operation.promise();
console.log(`Created development instance: ${instance.id}`);
// [END bigtable_create_dev_instance]
}
@@ -141,7 +146,11 @@ async function addCluster(instanceID, clusterID) {
storage: 'ssd',
};

const [cluster] = await instance.createCluster(clusterID, clusterOptions);
const [cluster, operation] = await instance.createCluster(
clusterID,
clusterOptions
);
await operation.promise();
console.log(`Cluster created: ${cluster.id}`);
// [END bigtable_create_cluster]
}