test: Add a test that ensures data is never re-requested when a retryable error occurs #1478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We intend to make code changes to ensure that ReadRows retries doesn't re-request data the server has already sent back. In order to guarantee that the client doesn't re-request data, this PR includes a test that verifies data is not re-requested. It is understood to address the change discussed in this document.
Changes:
Readrows.ts
ReadRowsImpl.ts
preprocessor
which is a function passed into the ReadRows service which will be called each time a request is received by the server. In the test, this parameter is used to pass in a function that does an assertion check against the request.