Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: Add a test that ensures data is never re-requested when a retryable error occurs #1478

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

danieljbruce
Copy link
Contributor

@danieljbruce danieljbruce commented Sep 24, 2024

Summary:

We intend to make code changes to ensure that ReadRows retries doesn't re-request data the server has already sent back. In order to guarantee that the client doesn't re-request data, this PR includes a test that verifies data is not re-requested. It is understood to address the change discussed in this document.

Changes:

Readrows.ts

  • Includes the new test that ensures data is not re-requested.

ReadRowsImpl.ts

  • Add a parameter called preprocessor which is a function passed into the ReadRows service which will be called each time a request is received by the server. In the test, this parameter is used to pass in a function that does an assertion check against the request.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/nodejs-bigtable API. labels Sep 24, 2024
@danieljbruce danieljbruce changed the title Re request data tests test: Add a test that ensures data is never re-requested when a retryable error occurs Sep 24, 2024
@danieljbruce danieljbruce marked this pull request as ready for review September 24, 2024 20:25
@danieljbruce danieljbruce requested review from a team as code owners September 24, 2024 20:25
@danieljbruce danieljbruce added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 24, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants