Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Move retries createreadstream get resumption logic working #1492

Merged
merged 194 commits into from
Sep 27, 2024
Merged

Move retries createreadstream get resumption logic working #1492

merged 194 commits into from
Sep 27, 2024

Conversation

kevkim-codes
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@danieljbruce
getRanges
a9b8d1b
@danieljbruce
Slight refactor of createReadStream
0f1b9eb
@danieljbruce
Add header to table utils
c75b4ed
@danieljbruce
Refactor range and keys getting
fcbd461
@danieljbruce
Pull request opts into a separate function
c2f4dfe
@danieljbruce
Revert "Pull request opts into a separate function"
4817863 
This reverts commit c2f4dfe.
@danieljbruce
logical separation of ranges and keys
810db82
@danieljbruce
Merge branch 'actually-refactor-createreadstream-2' of https://github…
648cc92 
….com/danieljbruce/nodejs-bigtable into actually-refactor-createreadstream-3
@danieljbruce
Revert "Revert "Pull request opts into a separate function""
b25b2c2 
This reverts commit 4817863.
@danieljbruce
set up the test frame
1b1947a
@danieljbruce
Test is set up to evaluate streaming behavior
59b2c26
@danieljbruce
Modify test with the mock server to pass first tst
baa5d8f
@danieljbruce
Fix tests that are appending startKey and endKey
869d5ce
@danieljbruce
Getting all the tests working
5e69834 
- Transform the rowsLimit parameter into an integer
- Change the hook into a before hook so that we don’t attempt to create multiple mock servers
- Create a guard so that the stream only writes if there are row keys to write
@danieljbruce
eliminate old createreadstream test
bf29061 
define new interfaces too
@danieljbruce
Remove only. rowsLimit should be optional
ad36097
@danieljbruce
Make rowKeysRead type more specific
2c57e61
@danieljbruce
Add after hook to shut down server
95b9463
@danieljbruce
Merge branch 'main' of https://github.com/googleapis/nodejs-bigtable …
1c66b3b 
…into move-retries-from-createreadstream

# Conflicts:
#	src/table.ts
#	src/utils/table.ts
@danieljbruce
Add the less than or equal to fn to utils
6324ad9
@danieljbruce
remove server start
8f51ddf
@danieljbruce
Add splice ranges back to diagnose problem
5edaf82
@danieljbruce
Revert "Add splice ranges back to diagnose problem"
575ae2b 
This reverts commit 5edaf82.
@danieljbruce
get all tests passing
0f80c35 
readRowsReqOpts should have an ECMAscript prefix to completely hide it from the user. Also remove a useless  Filter.parse.
@danieljbruce
Use tableUtils lessthanorequalto
b46f6b1
@danieljbruce
refactor: Move retries finish making createreadstream smaller
577ba7a
@danieljbruce
More specific type for options
03fb022
@danieljbruce
Import type and replace with any
752bf0b
@danieljbruce
Turn on gax streaming retries
4989fa4
@danieljbruce
Try out the shouldRetryFn
1f66d43
danieljbruce and others added 25 commits June 10, 2024 10:20
@danieljbruce
Remove comments and replace with constants
ac44217
@danieljbruce
Update the comment for getRowKeys
06feb74
@danieljbruce
Move variables inside the if statement
54483fd
@danieljbruce
Add a test case for row ranges and row keys
364738a
@danieljbruce
Add a test case that doesn’t do any filtering
ca3649d
@danieljbruce
Remove TODO
9468915
@danieljbruce
remove type any
918d193
@danieljbruce
Allow user to override codes
e01b96f 
Also update the keys and ranges every time.
@danieljbruce
Add another test for overriding the retry codes
642433c
@danieljbruce
Make the test a little bit more robust
77ce9b6
@danieljbruce
Update the test framework to measure shouldRetry
377185b
@danieljbruce
Add another test ensuring a retry doesn’t happen
4d288e8
@danieljbruce
rename the test
3df79ce
@danieljbruce
Make canResume always run unless shouldRetryFn pr
3b3196a
@danieljbruce
Gapic layer should expect empty retry codes
984fc8f
@danieljbruce
Remove copied file
f0bdc90
@danieljbruce
Change the resumption strategy
17aaae5
@danieljbruce
Replace 13 with enum
572b323
@danieljbruce
Removed example
149afaa
@danieljbruce
npm run fix
dd42118
@danieljbruce
Revert "npm run fix"
93b7fdb 
This reverts commit dd42118.
@danieljbruce
Merge branch 'main' into move-retries-createreadstream-get-resumption…
79ff3d9 
…-logic-working
@danieljbruce
Remove overrides
e22af7b
@danieljbruce
Remove irrelevant test
66e4b5a
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
1398dca 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@kevkim-codes kevkim-codes requested review from a team as code owners September 27, 2024 18:36
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/nodejs-bigtable API. labels Sep 27, 2024
@kevkim-codes kevkim-codes merged commit b43468e into googleapis:move-retries-createreadstream-get-resumption-logic-working Sep 27, 2024
21 of 30 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevkim-codes @danieljbruce