Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

359913994 third pr csm #1571

Draft
wants to merge 336 commits into
base: main
Choose a base branch
from
Draft

359913994 third pr csm #1571

wants to merge 336 commits into from

Conversation

danieljbruce
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

danieljbruce and others added 30 commits January 24, 2025 10:49
@danieljbruce
Metrics handler, GCPMetricsHandler and tests add
5995789
@danieljbruce
Remove only
a62b124
@danieljbruce
Merge branch 'main' of https://github.com/googleapis/nodejs-bigtable …
bfc5883 
…into 359913994-first-PR-add-infrastructure

# Conflicts:
#	testproxy/known_failures.txt
@danieljbruce
Add metrics handlers parameter to Doc
0996d3c
@danieljbruce
Don’t require retries to be passed into metrics
ef8e3fe 
collector
@danieljbruce
Remove testMeterProvider
c68a76f
@danieljbruce
Remove the attributesToString function
47a24b1
@danieljbruce
Eliminate unused class
b2600f2
@danieljbruce
Generate documentation for the IMetricsHandler
d4d3f6c
@danieljbruce
Generate documentation for GCPMetricsHandler
b8dff1c
@danieljbruce
Restrict attributes interfaces and solve compile
d50384f
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
b5fc1f2 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@danieljbruce
use undefined instead of null
1e5dc82
@danieljbruce
Introduce enums for allowable values
c2ffbc6
@danieljbruce
Merge branch '359913994-first-PR-add-infrastructure' of https://githu…
1200b3c 
…b.com/googleapis/nodejs-bigtable into 359913994-first-PR-add-infrastructure
@danieljbruce
Add more headers
9320149
@danieljbruce
Remove only
4023361
@danieljbruce
Use null to pass values around. Not undefined
ef91733
@danieljbruce
Modify test step
52b570c
@danieljbruce
Add metrics
6a6774f
@danieljbruce
Don’t provide first response latency
10b6d30
@danieljbruce
Remove firstResponseLatency from operation metrics
33c17c6
@danieljbruce
Expose interface allowing undefined not null
fbf2314
@danieljbruce
Better explanations for design decision inline
39fe861
@danieljbruce
Use attempt start time not operation start time
8f13100 
for firstResponseLatency
@danieljbruce
Adjust tests for first response latency
48e0e95
@danieljbruce
Remove TODO
66c4ab1
@danieljbruce
Use the MethodName enum instead of string
e7c5b5f
@danieljbruce
Don’t use enum for streaming operation
98be351
@danieljbruce
Remove copy/pasted comment
efdfcea
@danieljbruce
Cast as histogram to make compile error go away
b575010
@danieljbruce
Move the duplicate copies of replaceTimestamps
822c14e 
into one file
@danieljbruce
Take steps to eliminate the ExportInput interface
561889c
@danieljbruce
Add a header
f423c57
@danieljbruce
Remove only
9076be1
@danieljbruce
Eliminate ExportInput and dependencies
ead3f5e
@danieljbruce
Eliminate constant
fa6c3fd
@danieljbruce
Push conversion to status back to metrics collect
a587d0c 
Also add if statement for timeseries.
@danieljbruce
Change property names to match MetricServiceClient
311d555 
expectation
@danieljbruce
Solve the app_profile_id issue
117473b
@danieljbruce
It is actually app_profile not app_profile_id
e4154af
@danieljbruce
Add guards that stop the export call
0ccec5b
@danieljbruce
Remove only
9f94b9e
@danieljbruce
Add a new test for ten metrics handlers
7e76c39
@danieljbruce
Remove only
bb64fbe
@danieljbruce
Do not pass data through the Resource object
27f5bcd 
anymore
@danieljbruce
Add a test for writing duplicate points to MH
d1a292f
@danieljbruce
Eliminate interface
23a4d39
@danieljbruce
Set connectivity error count to 1 (not increment)
55dbd8f
@danieljbruce
Merge branch '359913994-exporter-PR' of https://github.com/googleapis…
69abb9a 
…/nodejs-bigtable into 359913994-third-PR-CSM

# Conflicts:
#	src/client-side-metrics/operation-metrics-collector.ts
@danieljbruce
Edit the fixtures
71b2d48
@danieljbruce
Remove the guard
c581129
@danieljbruce
Change attempt status to string
ba04208
@danieljbruce
Add a comment - undefined in conformance tests
9c3e5b1
@danieljbruce
Make metrics handlers per client
ab4545e
@danieljbruce
Add coment about latency
2d23a83
@danieljbruce
Wrap in try
efa147d
@danieljbruce
Adjust the proxyquire mocks to mock handler in
5761892 
right layer
@danieljbruce
Eliminate TODO
333c5b9
@danieljbruce
Eliminate TODO
3b71eff
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danieljbruce