-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore!: Upgrade to Node version 18 #1572
Open
danieljbruce
wants to merge
11
commits into
main
Choose a base branch
from
node-18-upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves the compiler errors
Replace dot prop with methods. Fix the issues with long and downgrade escapeStringRegexp.
Warning: This pull request is touching the following templated files:
|
); | ||
Object.assign(clusters[cluster.id!], { | ||
defaultStorageType: Cluster.getStorageType_(cluster.storage!), | ||
Object.assign(clusters[(cluster as ClusterInfo).id!], { |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
This assignment may alter Object.prototype if a malicious '__proto__' string is injected from .
library input
Error loading related location
Loading
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
api: bigtable
Issues related to the googleapis/nodejs-bigtable API.
size: l
Pull request size is large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.