Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use assert.deepStrictEqual instead of deepEqual. #253

Merged
merged 3 commits into from
Jul 24, 2018
Merged

Use assert.deepStrictEqual instead of deepEqual. #253

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca8c367
Use assert.deepStrictEqual instead of deepEqual.
sduskis Jul 23, 2018
429cbe1
Fixing more lint issues.
sduskis Jul 24, 2018
c258473
Setting hello world to node.js v8 for lint
sduskis Jul 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions samples/hello-world/package.json
View file
Original file line number Diff line number Diff line change
@@ -5,5 +5,8 @@
"dependencies": {
"@google-cloud/bigtable": "^0.15.0",
"co": "^4.6.0"
},
"engines": {
"node": ">=8.0.0"
}
}
22 changes: 13 additions & 9 deletions system-test/bigtable.js
View file
Original file line number Diff line number Diff line change
@@ -423,7 +423,7 @@ describe('Bigtable', function() {
assert.ifError(err);
assert.strictEqual(families.length, 3);
assert(families[0] instanceof Family);
assert.notEqual(
assert.notStrictEqual(
-1,
families
.map(f => {
@@ -554,7 +554,7 @@ describe('Bigtable', function() {
assert.ifError(err);
var maxAge = metadata.gcRule.maxAge;

assert.strictEqual(maxAge.seconds, rule.age.seconds);
assert.strictEqual(maxAge.seconds, rule.age.seconds.toString());
assert.strictEqual(maxAge.nanas, rule.age.nanas);
done();
});
@@ -942,7 +942,7 @@ describe('Bigtable', function() {
})
.sort();

assert.deepEqual(keys, ['alincoln', 'jadams', 'tjefferson']);
assert.deepStrictEqual(keys, ['alincoln', 'jadams', 'tjefferson']);

done();
});
@@ -1002,7 +1002,7 @@ describe('Bigtable', function() {
rows.forEach(function(row) {
var keys = Object.keys(row.data.follows).sort();

assert.deepEqual(keys, ['gwashington', 'jadams']);
assert.deepStrictEqual(keys, ['gwashington', 'jadams']);
});

done();
@@ -1087,7 +1087,7 @@ describe('Bigtable', function() {
assert(rows.length > 0);

var families = Object.keys(rows[0].data);
assert.deepEqual(families, ['traits']);
assert.deepStrictEqual(families, ['traits']);
done();
});
});
@@ -1121,7 +1121,7 @@ describe('Bigtable', function() {
})
.sort();

assert.deepEqual(ids, ['gwashington', 'tjefferson']);
assert.deepStrictEqual(ids, ['gwashington', 'tjefferson']);

done();
});
@@ -1140,7 +1140,7 @@ describe('Bigtable', function() {

Object.keys(follows).forEach(function(column) {
follows[column].forEach(function(cell) {
assert.deepEqual(cell.labels, [filter.label]);
assert.deepStrictEqual(cell.labels, [filter.label]);
});
});
});
@@ -1163,7 +1163,7 @@ describe('Bigtable', function() {
})
.sort();

assert.deepEqual(keys, ['gwashington', 'tjefferson']);
assert.deepStrictEqual(keys, ['gwashington', 'tjefferson']);

done();
});
@@ -1204,7 +1204,11 @@ describe('Bigtable', function() {

var columns = Object.keys(rows[0].data.follows).sort();

assert.deepEqual(columns, ['gwashington', 'jadams', 'tjefferson']);
assert.deepStrictEqual(columns, [
'gwashington',
'jadams',
'tjefferson',
]);

done();
});
6 changes: 3 additions & 3 deletions system-test/mutate-rows.js
View file
Original file line number Diff line number Diff line change
@@ -92,7 +92,7 @@ describe('Bigtable/Table', () => {
responses = test.responses;
TABLE.maxRetries = test.max_retries;
TABLE.mutate(test.mutations_request, error => {
assert.deepEqual(
assert.deepStrictEqual(
mutationBatchesInvoked,
test.mutation_batches_invoked
);
@@ -116,11 +116,11 @@ describe('Bigtable/Table', () => {
const expectedIndices = test.errors.map(error => {
return error.index_in_mutations_request;
});
assert.deepEqual(error.name, 'PartialFailureError');
assert.deepStrictEqual(error.name, 'PartialFailureError');
const actualIndices = error.errors.map(error => {
return test.mutations_request.indexOf(error.entry);
});
assert.deepEqual(expectedIndices, actualIndices);
assert.deepStrictEqual(expectedIndices, actualIndices);
} else {
assert.ifError(error);
}
2 changes: 1 addition & 1 deletion system-test/read-rows-acceptance-tests.js
View file
Original file line number Diff line number Diff line change
@@ -128,7 +128,7 @@ describe('Read Row Acceptance tests', function() {
function verify() {
assert.strictEqual(errors.length, errorCount, ' error count mismatch');
assert.strictEqual(rows.length, results.length, 'row count mismatch');
assert.deepEqual(rows, tableRows, 'row mismatch');
assert.deepStrictEqual(rows, tableRows, 'row mismatch');
done();
}
});
8 changes: 4 additions & 4 deletions test/app-profile.js
View file
Original file line number Diff line number Diff line change
@@ -182,7 +182,7 @@ describe('Bigtable/AppProfile', function() {
assert.strictEqual(config.client, 'BigtableInstanceAdminClient');
assert.strictEqual(config.method, 'deleteAppProfile');

assert.deepEqual(config.reqOpts, {
assert.deepStrictEqual(config.reqOpts, {
name: appProfile.name,
});

@@ -290,7 +290,7 @@ describe('Bigtable/AppProfile', function() {

it('should not require gaxOptions', function(done) {
appProfile.getMetadata = function(gaxOptions) {
assert.deepEqual(gaxOptions, {});
assert.deepStrictEqual(gaxOptions, {});
done();
};

@@ -332,11 +332,11 @@ describe('Bigtable/AppProfile', function() {
assert.strictEqual(config.client, 'BigtableInstanceAdminClient');
assert.strictEqual(config.method, 'getAppProfile');

assert.deepEqual(config.reqOpts, {
assert.deepStrictEqual(config.reqOpts, {
name: appProfile.name,
});

assert.deepEqual(config.gaxOpts, {});
assert.deepStrictEqual(config.gaxOpts, {});

done();
};
98 changes: 67 additions & 31 deletions test/chunktransformer.js
View file
Original file line number Diff line number Diff line change
@@ -66,20 +66,28 @@ describe('Bigtable/ChunkTransformer', function() {
this.qualifier = {};
this.row = {};
this.state = RowStateEnum.NEW_ROW;
assert.deepEqual(chunkTransformer.row, {}, 'invalid initial state');
assert.deepEqual(
assert.deepStrictEqual(chunkTransformer.row, {}, 'invalid initial state');
assert.deepStrictEqual(
chunkTransformer.prevRowKey,
null,
'invalid initial state'
);
assert.deepEqual(chunkTransformer.family, {}, 'invalid initial state');
assert.deepEqual(
assert.deepStrictEqual(
chunkTransformer.family,
{},
'invalid initial state'
);
assert.deepStrictEqual(
chunkTransformer.qualifiers,
[],
'invalid initial state'
);
assert.deepEqual(chunkTransformer.qualifier, {}, 'invalid initial state');
assert.deepEqual(
assert.deepStrictEqual(
chunkTransformer.qualifier,
{},
'invalid initial state'
);
assert.deepStrictEqual(
chunkTransformer.state,
RowStateEnum.NEW_ROW,
'invalid initial state'
@@ -204,7 +212,7 @@ describe('Bigtable/ChunkTransformer', function() {
},
},
};
assert.deepEqual(rows[0], expectedRow);
assert.deepStrictEqual(rows[0], expectedRow);
});
it('partial row ', function() {
const chunk = {
@@ -235,7 +243,7 @@ describe('Bigtable/ChunkTransformer', function() {
},
},
};
assert.deepEqual(chunkTransformer.row, partialRow);
assert.deepStrictEqual(chunkTransformer.row, partialRow);
assert.strictEqual(
chunkTransformer.state,
RowStateEnum.ROW_IN_PROGRESS,
@@ -271,7 +279,7 @@ describe('Bigtable/ChunkTransformer', function() {
},
},
};
assert.deepEqual(chunkTransformer.row, partialRow);
assert.deepStrictEqual(chunkTransformer.row, partialRow);
assert.strictEqual(
chunkTransformer.state,
RowStateEnum.CELL_IN_PROGRESS,
@@ -407,7 +415,7 @@ describe('Bigtable/ChunkTransformer', function() {
},
};
const row = rows[0];
assert.deepEqual(row, expectedRow, 'row mismatch');
assert.deepStrictEqual(row, expectedRow, 'row mismatch');
assert.strictEqual(
chunkTransformer.state,
RowStateEnum.NEW_ROW,
@@ -453,7 +461,7 @@ describe('Bigtable/ChunkTransformer', function() {
},
};
const row = rows[0];
assert.deepEqual(row, expectedRow, 'row mismatch');
assert.deepStrictEqual(row, expectedRow, 'row mismatch');
assert.strictEqual(
chunkTransformer.state,
RowStateEnum.NEW_ROW,
@@ -502,7 +510,7 @@ describe('Bigtable/ChunkTransformer', function() {
},
};
const row = rows[0];
assert.deepEqual(row, expectedRow, 'row mismatch');
assert.deepStrictEqual(row, expectedRow, 'row mismatch');
assert.strictEqual(
chunkTransformer.state,
RowStateEnum.NEW_ROW,
@@ -544,7 +552,7 @@ describe('Bigtable/ChunkTransformer', function() {
},
},
};
assert.deepEqual(
assert.deepStrictEqual(
chunkTransformer.row,
expectedState,
'row state mismatch'
@@ -596,7 +604,11 @@ describe('Bigtable/ChunkTransformer', function() {
},
},
};
assert.deepEqual(chunkTransformer.row, expectedState, 'row mismatch');
assert.deepStrictEqual(
chunkTransformer.row,
expectedState,
'row mismatch'
);
assert.strictEqual(
chunkTransformer.state,
RowStateEnum.ROW_IN_PROGRESS,
@@ -727,7 +739,7 @@ describe('Bigtable/ChunkTransformer', function() {
},
};
const row = rows[0];
assert.deepEqual(row, expectedRow, 'row mismatch');
assert.deepStrictEqual(row, expectedRow, 'row mismatch');
assert.strictEqual(
chunkTransformer.state,
RowStateEnum.NEW_ROW,
@@ -775,7 +787,11 @@ describe('Bigtable/ChunkTransformer', function() {
},
},
};
assert.deepEqual(chunkTransformer.row, expectedState, 'row mismatch');
assert.deepStrictEqual(
chunkTransformer.row,
expectedState,
'row mismatch'
);
assert.strictEqual(
chunkTransformer.state,
RowStateEnum.ROW_IN_PROGRESS,
@@ -834,7 +850,11 @@ describe('Bigtable/ChunkTransformer', function() {
},
},
};
assert.deepEqual(chunkTransformer.row, expectedState, 'row mismatch');
assert.deepStrictEqual(
chunkTransformer.row,
expectedState,
'row mismatch'
);
assert.strictEqual(
chunkTransformer.state,
RowStateEnum.ROW_IN_PROGRESS,
@@ -938,7 +958,7 @@ describe('Bigtable/ChunkTransformer', function() {
{},
callback
);
assert.deepEqual(chunkTransformer.lastRowKey, 'foo');
assert.deepStrictEqual(chunkTransformer.lastRowKey, 'foo');
});
});
describe('reset', function() {
@@ -962,20 +982,28 @@ describe('Bigtable/ChunkTransformer', function() {
};
this.state = RowStateEnum.CELL_IN_PROGRESS;
chunkTransformer.reset();
assert.deepEqual(chunkTransformer.row, {}, 'invalid initial state');
assert.deepEqual(
assert.deepStrictEqual(chunkTransformer.row, {}, 'invalid initial state');
assert.deepStrictEqual(
chunkTransformer.prevRowKey,
null,
'invalid initial state'
);
assert.deepEqual(chunkTransformer.family, {}, 'invalid initial state');
assert.deepEqual(
assert.deepStrictEqual(
chunkTransformer.family,
{},
'invalid initial state'
);
assert.deepStrictEqual(
chunkTransformer.qualifiers,
[],
'invalid initial state'
);
assert.deepEqual(chunkTransformer.qualifier, {}, 'invalid initial state');
assert.deepEqual(
assert.deepStrictEqual(
chunkTransformer.qualifier,
{},
'invalid initial state'
);
assert.deepStrictEqual(
chunkTransformer.state,
RowStateEnum.NEW_ROW,
'invalid initial state'
@@ -1008,20 +1036,28 @@ describe('Bigtable/ChunkTransformer', function() {
this.state = RowStateEnum.CELL_IN_PROGRESS;
chunkTransformer.commit();
assert(resetSpy.called, 'did not call reset');
assert.deepEqual(chunkTransformer.row, {}, 'invalid initial state');
assert.deepEqual(
assert.deepStrictEqual(chunkTransformer.row, {}, 'invalid initial state');
assert.deepStrictEqual(
chunkTransformer.prevRowKey,
'key',
'invalid initial state'
);
assert.deepEqual(chunkTransformer.family, {}, 'invalid initial state');
assert.deepEqual(
assert.deepStrictEqual(
chunkTransformer.family,
{},
'invalid initial state'
);
assert.deepStrictEqual(
chunkTransformer.qualifiers,
[],
'invalid initial state'
);
assert.deepEqual(chunkTransformer.qualifier, {}, 'invalid initial state');
assert.deepEqual(
assert.deepStrictEqual(
chunkTransformer.qualifier,
{},
'invalid initial state'
);
assert.deepStrictEqual(
chunkTransformer.state,
RowStateEnum.NEW_ROW,
'invalid initial state'
@@ -1072,7 +1108,7 @@ describe('Bigtable/ChunkTransformer', function() {
},
};
const row = rows[0];
assert.deepEqual(row, expectedRow, 'row mismatch');
assert.deepStrictEqual(row, expectedRow, 'row mismatch');
assert.strictEqual(
chunkTransformer.state,
RowStateEnum.NEW_ROW,
Loading