Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added example region-tags for cluster object #284

Merged
merged 8 commits into from
Nov 9, 2018

Conversation

vijay-qlogic
Copy link
Contributor

Fixes #157 partially for cluster.js

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2018
@codecov
Copy link

codecov bot commented Aug 28, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@3886233). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #284   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     10           
  Lines             ?   1269           
  Branches          ?      0           
=======================================
  Hits              ?   1269           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/cluster.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3886233...24f9bb5. Read the comment docs.

@vijay-qlogic vijay-qlogic force-pushed the tag-ex-comments-cluster branch from dd6b85a to 365980f Compare August 28, 2018 17:14
@vijay-qlogic vijay-qlogic changed the title added snippet code for cluster and respective region tags Added example region-tags for cluster object Aug 28, 2018
@vijay-qlogic vijay-qlogic force-pushed the tag-ex-comments-cluster branch 2 times, most recently from 86d6bb9 to 869bee5 Compare August 31, 2018 17:34
@vijay-qlogic vijay-qlogic force-pushed the tag-ex-comments-cluster branch from 869bee5 to 7da4461 Compare September 5, 2018 18:00
@vijay-qlogic vijay-qlogic force-pushed the tag-ex-comments-cluster branch from 7da4461 to e14c5bb Compare October 5, 2018 12:20
@ghost ghost assigned sduskis Oct 5, 2018
@sduskis
Copy link
Contributor

sduskis commented Nov 7, 2018

@dpebot merge on green

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2018
@sduskis sduskis merged commit f28a750 into googleapis:master Nov 9, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants