Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test: reap old instances before system tests #687

Merged
merged 3 commits into from
Apr 3, 2020
Merged

test: reap old instances before system tests #687

merged 3 commits into from
Apr 3, 2020

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 2, 2020
bcoe
bcoe approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use this pattern a lot and we should consider pulling it into a library.

@codecov
Copy link

codecov bot commented Apr 3, 2020 •
edited
Loading

Codecov Report

Merging #687 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #687   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files          15       15           
  Lines       15136    15136           
  Branches      870      932   +62     
=======================================
  Hits        14986    14986           
  Misses        147      147           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9abcaee...e68a0aa. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 7bcae14 into master Apr 3, 2020
@JustinBeckwith JustinBeckwith mentioned this pull request Apr 3, 2020
Closed
yoshi-automation added a commit that referenced this pull request Apr 3, 2020
@yoshi-automation
test: reap old instances before system tests (#687)
e183c4b 
7bcae14
commit 7bcae14
Author: Justin Beckwith <justin.beckwith@gmail.com>
Date:   Thu Apr 2 17:16:31 2020 -0700

    test: reap old instances before system tests (#687)
@stephenplusplus stephenplusplus deleted the sys branch August 10, 2020 17:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@crwilcox crwilcox crwilcox approved these changes

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JustinBeckwith @bcoe @crwilcox @alexander-fenster @googlebot