Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: set keepalive configuration #836

Merged
merged 2 commits into from
Jan 27, 2021
Merged

fix: set keepalive configuration #836

merged 2 commits into from
Jan 27, 2021

Conversation

stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Jan 20, 2021 •
edited
Loading

This adds two gRPC keepalive options:

  • GRPC_ARG_KEEPALIVE_TIME_MS to 30s
  • GRPC_ARG_KEEPALIVE_TIMEOUT_MS to 10s

@stephenplusplus stephenplusplus requested review from a team as code owners January 20, 2021 16:30
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 20, 2021
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/nodejs-bigtable API. label Jan 20, 2021
@codecov
Copy link

codecov bot commented Jan 20, 2021 •
edited
Loading

Codecov Report

Merging #836 (d511b06) into master (448465d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #836   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files          18       18           
  Lines       17416    17418    +2     
  Branches      952      952           
=======================================
+ Hits        17281    17283    +2     
  Misses        132      132           
  Partials        3        3
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 448465d...d511b06. Read the comment docs.

@alexander-fenster
Copy link
Contributor

Nitpicking on the title :) Is this really a feat, or maybe just a fix?

@bcoe bcoe changed the title feat: set keepalive configuration fix: set keepalive configuration Jan 27, 2021
@bcoe bcoe added the automerge Merge the pull request once unit tests and other checks pass. label Jan 27, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8105dea into googleapis:master Jan 27, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 27, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 11, 2021
@release-please
chore: release 3.3.0 (#850)
c7d202b 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.3.0](https://github.com/googleapis/nodejs-bigtable/compare/v3.2.0...v3.3.0) (2021-03-08)


### Features

* add CMEK fields ([#845](https://github.com/googleapis/nodejs-bigtable/issues/845)) ([0381fb7](https://github.com/googleapis/nodejs-bigtable/commit/0381fb7da68492b85f8a3359d5fb97ca4898810e))
* introduce style enumeration ([#833](https://github.com/googleapis/nodejs-bigtable/issues/833)) ([99b7617](https://github.com/googleapis/nodejs-bigtable/commit/99b7617e215126fc36ef3c3ebefb244e0d8d2242))
* **protos:** update BigtableTableAdmin GetIamPolicy, change DeleteAppProfileRequest.ignore_warnings to REQUIRED ([59a0d26](https://github.com/googleapis/nodejs-bigtable/commit/59a0d269d5196991dd395e671d7d5f54ce449005))


### Bug Fixes

* **browser:** check for fetch on window ([#824](https://github.com/googleapis/nodejs-bigtable/issues/824)) ([a38cbcc](https://github.com/googleapis/nodejs-bigtable/commit/a38cbcca1660bc40fe137acb973bf62f3c55754e))
* Renaming region tags to not conflict with documentation snippets ([#834](https://github.com/googleapis/nodejs-bigtable/issues/834)) ([5d3e8f7](https://github.com/googleapis/nodejs-bigtable/commit/5d3e8f721c2a32a33bf41baa1ed237fb90f7cbd6))
* **retry:** restore grpc_service_config for CreateBackup and RestoreTable ([#851](https://github.com/googleapis/nodejs-bigtable/issues/851)) ([3ff2828](https://github.com/googleapis/nodejs-bigtable/commit/3ff282855f4f9a52a89bca8d087c1423e71bd7c6))
* set keepalive configuration ([#836](https://github.com/googleapis/nodejs-bigtable/issues/836)) ([8105dea](https://github.com/googleapis/nodejs-bigtable/commit/8105dea272de44e69915d3e62e5b5add106b54cb))


---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@alvarowolfx alvarowolfx mentioned this pull request Aug 21, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alexander-fenster alexander-fenster

@kolea2 kolea2

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephenplusplus @alexander-fenster @kolea2 @bcoe