Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reject conflicting updates for nested maps #57

Merged
merged 6 commits into from
Nov 7, 2017

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Nov 6, 2017

This adds validation to reject updates for update("foo", {}, "foo.bar", {}).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2017
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt-conflictingfields branch from c306261 to 5413ecf Compare November 6, 2017 21:59
@codecov
Copy link

codecov bot commented Nov 6, 2017

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #57   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          11     11           
  Lines        1471   1478    +7     
=====================================
+ Hits         1471   1478    +7
Impacted Files Coverage Δ
src/write-batch.js 100% <100%> (ø) ⬆️
src/document.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aefc10...f7e65a3. Read the comment docs.

@schmidt-sebastian schmidt-sebastian merged commit 11983f6 into master Nov 7, 2017
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt-conflictingfields branch November 7, 2017 18:16
@schmidt-sebastian schmidt-sebastian changed the title Reject conflict updates for nested maps Reject conflicting updates for nested maps Nov 16, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants