Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(middleware): use bunyan log.child #163

Merged
merged 3 commits into from
Sep 28, 2018

Conversation

ofrobots
Copy link
Contributor

It turns out bunyan provides built-in support for Child loggers to
insert scope specific keys into the log metadata. This means that
we don't have to hand-roll an approximation to the bunyan API.

There should be no functional changes for JS users. TS users will see
the types change. Given that this support is clearly marked as
experimental in the docs, we are not going to deem these as semver
major changes.

It turns out bunyan provides built-in support for Child loggers to
insert scope specific keys into the log metadata. This means that
we don't have to hand-roll an approximation to the bunyan API.

There should be no functional changes for JS users. TS users will see
the types change. Given that this support is clearly marked as
experimental in the docs, we are not going to deem these as semver
major changes.
@ghost ghost assigned ofrobots Sep 26, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2018
Copy link

@soldair soldair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. these error_reporting system tests are a little flakey

@ofrobots ofrobots added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 26, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 26, 2018
@ofrobots ofrobots added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 28, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 28, 2018
@ofrobots ofrobots merged commit c4b4981 into googleapis:master Sep 28, 2018
@ofrobots ofrobots deleted the child-loggers-ftw branch September 28, 2018 01:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants