Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(deps): update dependency yargs to v13 #260

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 12, 2019

This PR contains the following updates:

Package Type Update Change References
yargs dependencies major ^12.0.0 -> ^13.0.0 homepage, source

Release Notes

yargs/yargs

v13.1.0

Compare Source

Features
  • add applyBeforeValidation, for applying sync middleware before validation (5be206a)

Renovate configuration

📅 Schedule: "after 9am and before 3pm" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 12, 2019
@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2019
@@ -17,7 +17,7 @@
"@google-cloud/logging-bunyan": "^0.9.5",
"bunyan": "^1.8.12",
"express": "^4.16.3",
"yargs": "^12.0.0"
"yargs": "^13.0.0"
Copy link
Contributor

@ofrobots ofrobots Feb 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense for this to be in devDependencies instead? (/tangential)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all fake money, since these modules never get published. That having been said - yargs is required to run the sample itself, so I'd say regular deps sounds right.

@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2019
@renovate renovate bot force-pushed the renovate/yargs-13.x branch from 908680e to b75536a Compare February 12, 2019 22:26
@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #260 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #260   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files           2        2           
  Lines          73       73           
  Branches        6        6           
=======================================
  Hits           67       67           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a694d3...b2af3ed. Read the comment docs.

@ofrobots ofrobots added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2019
@renovate renovate bot force-pushed the renovate/yargs-13.x branch from b75536a to b2af3ed Compare February 13, 2019 23:15
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2019
@JustinBeckwith JustinBeckwith merged commit f6eb4cd into master Feb 14, 2019
@renovate renovate bot deleted the renovate/yargs-13.x branch February 14, 2019 03:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants