-
Notifications
You must be signed in to change notification settings - Fork 314
fix: add google-auth as a direct dependency #1809
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
@parthea
|
@parthea This conflict is preventing us from closing this PR. |
I think the minimum version of google-api-core should be bumped to |
Most recent conflict errors that need resolution:
|
@chalmerlowe This seems to be just a problem in python 3.7, which I believe we plan to deprecate for this library anyway no? |
Theoretically, yes. Deprecation plans are on hold for a bit. Will explain more in internal chat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
google.auth
is used in this repository and should be added as a direct dependency so that the minimum version can be stated and testedhttps://github.com/search?q=repo%3Agoogleapis%2Fpython-bigquery%20google.auth&type=code
python-bigquery/setup.py
Lines 31 to 44 in 6249032
BEGIN_COMMIT_OVERRIDE
fix(deps): Require google-api-core>=1.34.1, >=2.11.0
fix: add google-auth as a direct dependency
END_COMMIT_OVERRIDE