[gen-manifest] Support passing any sample key/value pairs #70
Comments
beccasaurus
changed the title
path: should be (a) relative (b) configurable via --path
|
Important: please continue to support all existing flags until we deprecate the old schema We have tools that pass --bin --env --invocation --chdir etc They can just be shorthand for setting those key/values :) |
vchudnov-g
added a commit
that referenced
this issue
Jun 20, 2019
…ary labels (#74) * Add tests to existing gen-manifest functionality * Allow gen-manifest to generate manifests conforming to schema v3 (schema v2 remains the default) * When generating in schema v3, allow the manifest to be in a factored form (with common fields in a YAML anchor block referenced from the manifest list) or in a flat form (each list item repeats the common fields). This is controlled by the flag `--flat` (default is `false`, ie. factored output for similarity with how schema v2 was generating) * For both schema v2 and schema v3, allow passing arbitrary --KEY=VALUE pairs on the command line, which are interpreted as tags that apply to all elements (addresses #70) * Forbid certain KEY names (`sample`, `path`, and sometimes `basepath`) that we autogenerate based on the sample location/contents * Tests for the above
yoshi-automation
added
🚨
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
The new manifest no longer has a top-level --path/--bin/etc
Let's update gen-manifest so that it can set any key/value for a sample.
Because
gen-manifestcreates N samples, it's good if each --key/value pair is set on EVERY sample.So, passing --path X results in EVERY sample in the manifest having path: X
@googleapis/samplegen
The text was updated successfully, but these errors were encountered: