Update Sample #869
Open
Update Sample #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vorburger
added a commit
to vorburger/codelab-4-codelab
that referenced
this pull request
Oct 28, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As-is it was broken, because CSS URL changed at some point.
It looked "ugly", like https://www.marcd.dev/codelab-4-codelab/.
But the real question here may be if this should be committed into git at all? Shouldn't
claat export sample/codelab.mdbetter run in a GitHub Action, instead? And the result published... somewhere? I'll raise a separate issue to further discuss that separately; until that's decided, perhaps this still makes sense.