Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fuzzer aborts/panics in IFT implementation #1280

Closed
drott opened this issue Dec 9, 2024 · 3 comments
Closed

Fuzzer aborts/panics in IFT implementation #1280

drott opened this issue Dec 9, 2024 · 3 comments
Assignees
@garretrieger

Comments

@drott
Copy link
Contributor

drott commented Dec 9, 2024 •
edited
Loading

See
https://g-issues.oss-fuzz.com/issues/382721852
and
https://g-issues.oss-fuzz.com/issues/382927070

@garretrieger, could you please fix those? Thanks.
@garretrieger
Copy link
Contributor

Panic is coming from the uri template library we're using. Unfortunately it looks like the crate doesn't implement proper error handling. I'm leaning towards writing our own uri template expansion implementation instead.

garretrieger added a commit that referenced this issue Jan 2, 2025
@garretrieger
[IFT] switch to uri_template_system crate for URI template expansion.
5479137 
The uri-template crate panics when encountering errors so switch to the uri-template-system crate which has error handling built into the API. Fixes fuzzer crashes from #1280.
@garretrieger garretrieger mentioned this issue Jan 2, 2025
Merged
@drott
Copy link
Contributor Author

drott commented Jan 7, 2025

Unfortunately it looks like the crate doesn't implement proper error handling. I'm leaning towards writing our own uri template expansion implementation instead.

SGTM, also in the interest of reducing dependencies.

garretrieger added a commit that referenced this issue Jan 7, 2025
@garretrieger
[IFT] switch to uri_template_system crate for URI template expansion.
98f9f2e 
The uri-template crate panics when encountering errors so switch to the uri-template-system crate which has error handling built into the API. Fixes fuzzer crashes from #1280.
@garretrieger
Copy link
Contributor

Fuzzer issues have been marked as fixed.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@garretrieger garretrieger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drott @garretrieger