Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Basic compilation of variation tables #169

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Basic compilation of variation tables #169

merged 2 commits into from
Dec 9, 2022

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Dec 9, 2022

This isn't super useful as-is; we will need builders for these types that have various packed representations, but this at least gets the types in place so that they can be referenced by other tables.

Copy link
Member

@dfrg dfrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I assume with this in place that the item_var_store_offset field in GDEF can be properly typed now?

@cmyr
Copy link
Member Author

cmyr commented Dec 9, 2022

@dfrg yes, good call, I'll add that here.

@cmyr cmyr force-pushed the compile-variations branch from 78898f0 to dd76713 Compare December 9, 2022 20:41
cmyr added 2 commits December 9, 2022 15:47
This isn't super useful as-is; we will need builders for these types
that have various packed representations, but this at least gets the
types in place so that they can be referenced by other tables.
@cmyr cmyr force-pushed the compile-variations branch from dd76713 to f1b7a2d Compare December 9, 2022 20:48
@cmyr cmyr merged commit c90c03d into main Dec 9, 2022
@cmyr cmyr deleted the compile-variations branch December 9, 2022 21:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants