Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix incorrect format value for CharacterVariantParams #176

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Fix incorrect format value for CharacterVariantParams #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion read-fonts/generated/generated_layout.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4399,7 +4399,7 @@ impl<'a> std::fmt::Debug for StylisticSetParams<'a> {
}

impl Format<u16> for CharacterVariantParamsMarker {
const FORMAT: u16 = 1;
const FORMAT: u16 = 0;
}

/// featureParams for ['cv01'-'cv99'](https://docs.microsoft.com/en-us/typography/opentype/spec/features_ae#cv01-cv99)
Expand Down
2 changes: 1 addition & 1 deletion resources/codegen_inputs/layout.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,7 @@ table StylisticSetParams {
/// featureParams for ['cv01'-'cv99'](https://docs.microsoft.com/en-us/typography/opentype/spec/features_ae#cv01-cv99)
table CharacterVariantParams {
/// Format number is set to 0.
#[format = 1]
#[format = 0]
format: u16,
/// The 'name' table name ID that specifies a string (or strings,
/// for multiple languages) for a user-interface label for this
Expand Down
2 changes: 1 addition & 1 deletion write-fonts/generated/generated_layout.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2972,7 +2972,7 @@ impl CharacterVariantParams {
impl FontWrite for CharacterVariantParams {
#[allow(clippy::unnecessary_cast)]
fn write_into(&self, writer: &mut TableWriter) {
(1 as u16).write_into(writer);
(0 as u16).write_into(writer);
self.feat_ui_label_name_id.write_into(writer);
self.feat_ui_tooltip_text_name_id.write_into(writer);
self.sample_text_name_id.write_into(writer);
Expand Down