Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix incorrect size calculation for MacRoman strings #178

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Fix incorrect size calculation for MacRoman strings #178

merged 1 commit into from
Dec 16, 2022

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Dec 14, 2022

We were counting bytes and not chars.

@cmyr
Fix incorrect size calculation for MacRoman strings
c499429 
We were counting bytes and not chars.
dfrg
dfrg approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@dfrg dfrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@cmyr cmyr merged commit 8ab86d1 into main Dec 16, 2022
@cmyr cmyr deleted the compute-name-len branch December 16, 2022 21:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dfrg dfrg dfrg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmyr @dfrg