post gh report then raise exit code

googlefonts · Dec 14, 2023 · ffaf8e5 · ffaf8e5
1 parent f09d250
commit ffaf8e5
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/Lib/gftools/qa.py b/Lib/gftools/qa.py
@@ -122,9 +122,6 @@ def fontbakery(self, profile="googlefonts", html=False, extra_args=None):
         if extra_args:
             cmd.extend(extra_args)
         process = subprocess.run(cmd)
-        if process.returncode != 0:
-            logger.fatal("Fontbakery has raised a fatal error. Please fix!")
-            sys.exit(1)
 
         fontbakery_report = os.path.join(self.out, "Fontbakery", "report.md")
         if not os.path.isfile(fontbakery_report):
@@ -136,6 +133,10 @@ def fontbakery(self, profile="googlefonts", html=False, extra_args=None):
             msg = doc.read()
             self.post_to_github(msg)
 
+        if process.returncode != 0:
+            logger.fatal("Fontbakery has raised a fatal error. Please fix!")
+            sys.exit(1)
+
     def googlefonts_upgrade(self, imgs=False):
         self.fontbakery()
         self.diffenator()