qa: return errcode 1 if fontbakery reports a fatal error #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
LGTM. Please remember that |
| @@ -131,6 +133,10 @@ def fontbakery(self, profile="googlefonts", html=False, extra_args=None): | |||
| msg = doc.read() | |||
| self.post_to_github(msg) | |||
|
|
|||
| if process.returncode != 0: | |||
| logger.fatal("Fontbakery has raised a fatal error. Please fix!") | |||
There was a problem hiding this comment.
In the future, my goal is to gradually change the threshold in this CI setup. So, instead of saying "raised a fatal error", this could say: "There are check results at the current threshold: FATAL"
And in the future that would become something like:
"There are check results at (or worse than) the current threshold: FAIL severity 10"
|
thanks! ;-) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will merge once a new fontbakery release is cut. PR implementation will simply log a fatal error and stop all other checks from running.
cc @simoncozens @felipesanches