[qa] Allow multiple --extra-fontbakery-args #812
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--extra-fontbakery-args
is a flag ongftools-qa
which passes another flag to fontbakery. Of course this causes problems. If you say--extra-fontbakery-args --foo
this gets interpreted as a--foo
flag togftools-qa
."--foo"
doesn't help because the shell eats the quotes. Apparently the right way to do it is--extra-fontbakery-args="--foo"
which parses properly. But then--extra-fontbakery-args="--foo bar"
works on thegftools-qa
side, but adds a single string "--foo bar" string to fontbakery's argv, which does not parse on that side. Much joy. And you really don't want to get into splitting arguments on spaces and feeding them to argv, because--html "A Report.html"
should be two arguments, not three. And--extra-fontbakery-args="--foo" "bar"
doesn't work either.So (deep breath) it turns out the right way to do it is
--extra-fontbakery-args="--foo" --extra-fontbakery-args="bar"
, and that in turn means we need to useaction="append"
instead ofnargs="*"
.