Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrate from github.com/golang/protobuf to google.golang.org/protobuf #29

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

govargo
Copy link
Collaborator

@govargo govargo commented Apr 18, 2023

Fix #28

In this PR, I changed from github.com/golang/protobuf to google.golang.org/protobuf, because github.com/golang/protobuf would be deprecated in the future.

Change
・Upgrade golang:1.20:
Dedicated.Dockerfile, Director.Dockerfile, Frontend.Dockerfile, Mmf.Dockerfile ,Dockerfile.build-protos
・Re-generate automatically by protoc:
game/pb/messages.pb.go
・Migrade from github.com/golang/protobuf to google.golang.org/protobuf:
game/game.go, game/protostream/protostream.go, Dockerfile.build-protos
・Refactor for more readable
build_protos.sh

@govargo govargo added the enhancement New feature or request label Apr 18, 2023
@govargo govargo requested a review from kemurayama April 18, 2023 08:23
@govargo
Copy link
Collaborator Author

govargo commented Apr 18, 2023

I tested on my GKE cluster and it looked good
スクリーンショット 2023-04-18 18 02 32

@govargo govargo changed the title Migrade from github.com/golang/protobuf to google.golang.org/protobuf Migrate from github.com/golang/protobuf to google.golang.org/protobuf Apr 19, 2023
Copy link
Collaborator

@kemurayama kemurayama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed LGTM.

@kemurayama kemurayama merged commit 025fea7 into googleforgames:main Apr 24, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrade from github.com/golang/protobuf to google.golang.org/protobuf
2 participants