-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
CPP style NDR formatting #21
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Has the CLA sign off any propagation delays? I've submitted that like 15 minutes ago. |
@googlebot I fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a shame that I didn't make it easier to write your own formatter in the first place rather than having to modify this library rather than just OleViewDotNet. Anyway some things you'll need to fix up before I'll consider merging.
LGTM. Although it's still complaining about the CLA. You need to ensure you've signed the CLA and mark the patches with the email address you specified in the CLA. |
@googlebot I fixed it. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@tyranid : Yeah, and the complaint was actually fully correct; I had an old email address configured. It is now fixed for real. |
Committed. Give me a day or so to make a release of NtApiDotNet to update the OVDN package. |
The PR I'm submitting about OVDN relies on this change.