Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support React 18 #1

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Conversation

lh0x00
Copy link
Contributor

@lh0x00 lh0x00 commented Dec 28, 2022

This update includes the following:

  • Support running on React 18, is currently not possible (in development mode).
  • Support for reuseMaps: true with the previous container.

Please review, merge and publish the new version. ^^

cc @iBinh

@lh0x00
Copy link
Contributor Author

lh0x00 commented Dec 29, 2022

Pending review and publication of a new version, my company is using its fork version goong-map-react-plus, may be useful if anyone needs it.

@iBinh
Copy link
Contributor

iBinh commented Dec 29, 2022

LGTM, thanks!

@iBinh iBinh closed this Dec 29, 2022
@iBinh iBinh reopened this Dec 29, 2022
@iBinh iBinh merged commit 03ab7a0 into goong-io:main Dec 29, 2022
@lh0x00 lh0x00 deleted the bugfix/SupportNewestReactVersion branch December 29, 2022 08:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants